Copilot commented on code in PR #64727: URL: https://github.com/apache/doris/pull/64727#discussion_r3458130776
########## build.sh: ########## @@ -703,6 +703,7 @@ echo "Get params: FEAT=() FEAT+=($(feature_enabled "tde" && echo "+TDE" || echo "-TDE")) FEAT+=($(feature_enabled "tls" && echo "+TLS" || echo "-TLS")) +FEAT+=($(feature_enabled "variant-nested-group" && echo "+VARIANT_NESTED_GROUP" || echo "-VARIANT_NESTED_GROUP")) Review Comment: Avoid unquoted command substitution in array appends here. If `feature_enabled` ever emits output (e.g., via debug `echo`) or if the echoed token changes to include whitespace, word-splitting could add unintended extra array elements. Prefer using a single, quoted element assignment (or `if feature_enabled ...; then FEAT+=(\"+...\"); else FEAT+=(\"-...\"); fi`) to ensure exactly one array item is appended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
