github-actions[bot] commented on code in PR #64376:
URL: https://github.com/apache/doris/pull/64376#discussion_r3460894478
##########
regression-test/suites/insert_p0/mow_insert_with_partition_drop.groovy:
##########
@@ -49,19 +49,26 @@ suite("mow_insert_with_partition_drop") {
j++
} catch (Exception e) {
logger.info("exception=" + e.getMessage())
- assertTrue(e.getMessage().contains("Insert has filtered data
in strict mode. url:") ||
- (e.getMessage().contains("partition") &&
e.getMessage().contains("does not exist")))
+ assertTrue((e.getMessage().contains("Insert has filtered data
in strict mode")
Review Comment:
In internal group-commit regression mode this insert can return the
group-commit filtered-row error instead of the normal insert strict-mode text.
`isEnableInsertGroupCommit()` becomes true when
`wait_internal_group_commit_finish` is true, and this table/`INSERT ... VALUES`
path satisfies the group-commit eligibility checks (OLAP table, light schema
change, no explicit partitions, one-row values insert). BE then reports
filtered rows as `too many filtered rows`, and nearby tests branch on
`isGroupCommitMode() ? "too many filtered rows" : "Insert has filtered data in
strict mode"`. With this allow-list, the suite still fails under that config
once `t1.get()` propagates the assertion. Please include the group-commit error
text, preferably using the existing `isGroupCommitMode()` pattern, while
retaining the dropped-partition case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
