github-actions[bot] commented on code in PR #64755:
URL: https://github.com/apache/doris/pull/64755#discussion_r3464092772
##########
be/src/exec/scan/olap_scanner.cpp:
##########
@@ -301,8 +301,10 @@ Status OlapScanner::_open_impl(RuntimeState* state) {
auto res = _tablet_reader->init(_tablet_reader_params);
if (!res.ok()) {
- res.append("failed to initialize storage reader. tablet=" +
- std::to_string(_tablet_reader_params.tablet->tablet_id()) +
+ // init() also runs the eager first-row read that evaluates
pushed-down expressions,
+ // so res may be a data/expression error rather than a storage
failure. Keep its own
+ // message and only append the tablet/backend, without a misleading
storage wording.
+ res.append(". tablet=" +
std::to_string(_tablet_reader_params.tablet->tablet_id()) +
Review Comment:
This wording change leaves
`regression-test/suites/fault_injection_p0/test_index_compound_directory_fault_injection.groovy`
stale. That test still does `assertTrue(ex.toString().contains("failed to
initialize storage reader"))`, but after this hunk the scanner no longer
appends that phrase on any `_tablet_reader->init()` failure; a repo-wide search
only finds the test assertion. Please update the regression expectation to
assert the underlying injected error and/or the new `tablet=`/`backend=`
context, otherwise the fault-injection suite will fail for the intended new
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
