github-actions[bot] commented on code in PR #62661:
URL: https://github.com/apache/doris/pull/62661#discussion_r3464510484
##########
regression-test/suites/load_p0/insert/test_insert_random_distribution_table.groovy:
##########
@@ -15,9 +15,15 @@
// specific language governing permissions and limitations
// under the License.
-suite("test_insert_random_distribution_table", "p0") {
+suite("test_insert_random_distribution_table", "p0,nonConcurrent") {
def tableName = "test_insert_random_distribution_table"
+ def enableAdaptiveRandomBucketConfig = sql """ ADMIN SHOW FRONTEND CONFIG
LIKE 'enable_adaptive_random_bucket_load'; """
+ String oldEnableAdaptiveRandomBucket =
enableAdaptiveRandomBucketConfig[0][1]
+ try {
+ // This case verifies the legacy batch-size based random tablet
rotation.
+ // Keep the suite nonConcurrent because this FE config is global.
+ sql """ ADMIN SET FRONTEND CONFIG
('enable_adaptive_random_bucket_load' = 'false') """
Review Comment:
This suite now disables `enable_adaptive_random_bucket_load`, but the PR
turns that feature on by default and changes the FE planning, thrift/protobuf
fields, BE sender routing, and receiver-side rotation path. The added unit
tests only exercise helper assignment/state logic, and I do not see any
regression/integration test that runs a real random-distribution load with
adaptive mode enabled. Please add an end-to-end test that leaves the feature
enabled (cloud mode if required) and verifies the planned adaptive assignments
are propagated and rows are routed/loaded correctly, or add the closest
executable integration coverage for that path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
