morningman opened a new pull request, #64772:
URL: https://github.com/apache/doris/pull/64772

   ### What problem does this PR solve?
   
   Issue Number: #64464
   
   Related PR: #64757 (the branch-4.1 fix this follows up on)
   
   Problem Summary:
   
   Test-only follow-up to #64757 (already merged into `branch-4.1`), addressing 
review feedback on the SQL Server `bit` pushdown regression test.
   
   The merged test executed `select * from test_binary where bit_value in ('1', 
'0')` without asserting the pushed-down form, and because the IN list covers 
every value of a `bit` column it matched all rows — so it would still pass if 
the IN predicate were dropped, or rendered with `TRUE`/`FALSE` instead of 
`1`/`0`.
   
   This PR:
   - adds an `explain` assertion that the pushed remote SQL renders the IN with 
integer literals (`[bit_value] IN (1, 0)`);
   - replaces the non-asserting executions with selective `order_qt` cases (`= 
'0'` -> id=1, `= '1'` -> id=2,3) that fail if the filter is not applied, with 
matching `.out` baselines.
   
   No production code change — the boolean pushdown fix itself already landed 
in `branch-4.1` via #64757.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test
       - [x] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test.
   
   - Behavior changed:
       - [x] No.
       - [ ] Yes.
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to