github-actions[bot] commented on code in PR #64614:
URL: https://github.com/apache/doris/pull/64614#discussion_r3464993580


##########
regression-test/suites/query_profile/test_writer_profile.groovy:
##########
@@ -191,4 +193,7 @@ suite('test_writer_profile', "nonConcurrent") {
         sql "set enable_profile=false;"
         sql "set profile_level=1;"
     }
-}
\ No newline at end of file
+
+    sql "drop table if exists ${level1TableName};"

Review Comment:
   These generated table names are only dropped after both profile checks 
complete. If either insert/profile lookup/assertion throws, execution exits 
before these drops, and the next run uses different timestamped names so it 
will not clean up the leaked tables. Please wrap the whole table lifecycle in 
an outer `try/finally` that drops both generated names, or keep deterministic 
table names that are cleaned at the beginning and end.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to