0AyanamiRei opened a new pull request, #64773:
URL: https://github.com/apache/doris/pull/64773
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
JSON Stream Load handled JSON numeric values for BOOLEAN columns through
string boolean parsing, so non-zero numeric values such as 1235 could be loaded
as NULL in nullable BOOLEAN columns while INSERT cast them to true. This PR
handles JSON typed numeric BOOLEAN values before string parsing, making zero
false and non-zero true.
### Release note
Fix JSON Stream Load BOOLEAN conversion for numeric JSON values.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- `./run-be-ut.sh --run
--filter=NewJsonReaderBoolNumberTest.CheckJsonNumberIsNonzero -j60`
- `build-support/check-format.sh`
- `git diff --check`
- `./run-regression-test.sh --run -d insert_p0 -s insert -ha
10.26.20.4:8030` was blocked by local Stream Load HTTP 401 before reaching the
new case.
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. JSON Stream Load now casts numeric JSON values loaded into
BOOLEAN with numeric cast semantics: zero is false and non-zero is true.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
