github-actions[bot] commented on PR #15545:
URL: https://github.com/apache/doris/pull/15545#issuecomment-1368242009
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/3812716117";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build-for-release.sh line 32:
Usage: $0 --version "version" <options>
^-----^ SC2140 (warning): Word is of the form "A"B"C"
(B indicated). Did you mean "ABC" or "A\"B\"C"?
In build-for-release.sh line 137:
rm -rf ${OUTPUT}
^-------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
Did you mean:
rm -rf "${OUTPUT}"
In build-for-release.sh line 138:
mkdir -p ${OUTPUT_FE} ${OUTPUT_BE} ${OUTPUT_DEPS}
^----------^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^----------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^------------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "${OUTPUT_FE}" "${OUTPUT_BE}" "${OUTPUT_DEPS}"
In build-for-release.sh line 141:
cp -R ${ORI_OUTPUT}/fe/* ${OUTPUT_FE}/
^-----------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^----------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
cp -R "${ORI_OUTPUT}"/fe/* "${OUTPUT_FE}"/
In build-for-release.sh line 144:
cp ${ORI_OUTPUT}/be/lib/java-udf-jar-with-dependencies.jar ${OUTPUT_DEPS}/
^-----------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^------------^
SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp "${ORI_OUTPUT}"/be/lib/java-udf-jar-with-dependencies.jar
"${OUTPUT_DEPS}"/
In build-for-release.sh line 145:
cp -R ${ORI_OUTPUT}/apache_hdfs_broker ${OUTPUT_DEPS}/apache_hdfs_broker
^-----------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^------------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
Did you mean:
cp -R "${ORI_OUTPUT}"/apache_hdfs_broker "${OUTPUT_DEPS}"/apache_hdfs_broker
In build-for-release.sh line 146:
cp -R ${ORI_OUTPUT}/audit_loader ${OUTPUT_DEPS}/audit_loader
^-----------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^------------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
Did you mean:
cp -R "${ORI_OUTPUT}"/audit_loader "${OUTPUT_DEPS}"/audit_loader
In build-for-release.sh line 149:
cp -R ${ORI_OUTPUT}/be/* ${OUTPUT_BE}/
^-----------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^----------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
cp -R "${ORI_OUTPUT}"/be/* "${OUTPUT_BE}"/
In build-for-release.sh line 150:
rm ${OUTPUT_BE}/lib/java-udf-jar-with-dependencies.jar
^----------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
Did you mean:
rm "${OUTPUT_BE}"/lib/java-udf-jar-with-dependencies.jar
In build-for-release.sh line 154:
cd ${OUTPUT}
^-------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
Did you mean:
cd "${OUTPUT}"
In build-for-release.sh line 155:
tar -cf - ${FE} | xz -T0 -z - > ${FE}.tar.xz
^---^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^---^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
tar -cf - "${FE}" | xz -T0 -z - > "${FE}".tar.xz
In build-for-release.sh line 156:
tar -cf - ${BE} | xz -T0 -z - > ${BE}.tar.xz
^---^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^---^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
tar -cf - "${BE}" | xz -T0 -z - > "${BE}".tar.xz
In build-for-release.sh line 157:
tar -cf - ${DEPS} | xz -T0 -z - > ${DEPS}.tar.xz
^-----^ SC2086 (info): Double quote to prevent globbing and
word splitting.
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
tar -cf - "${DEPS}" | xz -T0 -z - > "${DEPS}".tar.xz
For more information:
https://www.shellcheck.net/wiki/SC2140 -- Word is of the form "A"B"C" (B
in...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build-for-release.sh.orig
+++ build-for-release.sh
@@ -110,10 +110,9 @@
"
sh build.sh --clean &&
-USE_AVX2="${_USE_AVX2}" sh build.sh &&
-USE_AVX2="${_USE_AVX2}" sh build.sh --be --meta-tool &&
-
-echo "Begin to pack"
+ USE_AVX2="${_USE_AVX2}" sh build.sh &&
+ USE_AVX2="${_USE_AVX2}" sh build.sh --be --meta-tool &&
+ echo "Begin to pack"
ORI_OUTPUT="${ROOT}/output"
FE=apache-doris-fe-${VERSION}-bin-x86_64
@@ -152,9 +151,9 @@
if [[ "${TAR}" -eq 1 ]]; then
echo "Begin to compress"
cd ${OUTPUT}
- tar -cf - ${FE} | xz -T0 -z - > ${FE}.tar.xz
- tar -cf - ${BE} | xz -T0 -z - > ${BE}.tar.xz
- tar -cf - ${DEPS} | xz -T0 -z - > ${DEPS}.tar.xz
+ tar -cf - ${FE} | xz -T0 -z - >${FE}.tar.xz
+ tar -cf - ${BE} | xz -T0 -z - >${BE}.tar.xz
+ tar -cf - ${DEPS} | xz -T0 -z - >${DEPS}.tar.xz
cd -
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
