sollhui opened a new pull request, #64779:
URL: https://github.com/apache/doris/pull/64779
### What problem does this PR solve?
`S3FileWriter` did not handle two async submit failure paths correctly.
1. Upload buffer submit failure:
The writer added the upload task to `_countdown_event` before submitting
it to the async upload thread pool. If `FileBuffer::submit()` failed, the task
would never run, so `_complete_part_task_callback()` would not be called. This
could hide the real failure and leave later close/destructor paths waiting for
a countdown that would never be released.
2. Async close submit failure:
`close(true)` could leave the writer in `ASYNC_CLOSING` after failing to
submit the close task, without a valid future completion path. Later
`try_finish_close()` or destructor logic could then observe an inconsistent
async-close state.
This PR centralizes S3 upload-buffer submission so submit failures go
through the normal completion callback and release the countdown. It also falls
back to synchronous close when async close task submission fails, returning the
real close result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
