Mryange opened a new pull request, #64828:
URL: https://github.com/apache/doris/pull/64828

   
   ### What problem does this PR solve?
   
   `BIGINT_MIN DIV -1` can trigger signed integer overflow in BE `int_divide` 
and terminate the backend with `SIGFPE`. Root cause: `DivideIntegralImpl` only 
handled division by zero, but did not guard the undefined signed case where the 
minimal signed integer is divided by `-1`. This change follows the existing 
`mod`/`pmod` behavior and returns `INVALID_ARGUMENT` before executing the 
unsafe division. The guard covers const/const, vector/const, const/vector, and 
vector/vector paths.
   
   
   https://godbolt.org/z/YPq9W581e
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to