github-actions[bot] commented on code in PR #64828:
URL: https://github.com/apache/doris/pull/64828#discussion_r3478973678
##########
be/test/exprs/function/function_arithmetic_test.cpp:
##########
@@ -53,6 +54,76 @@ TEST(function_arithmetic_test,
function_arithmetic_divide_test) {
}
}
+TEST(function_arithmetic_test,
function_arithmetic_int_divide_min_signed_by_minus_one_test) {
+ std::string func_name = "int_divide";
Review Comment:
The new guard also changes the registered TINYINT and SMALLINT `int_divide`
kernels, but this test only covers INT, BIGINT, and LARGEINT.
`register_function_int_div()` still registers
`DivideIntegralImpl<TYPE_TINYINT>` and `DivideIntegralImpl<TYPE_SMALLINT>`, and
same-type TINYINT/SMALLINT operands can keep those exact common types before BE
execution. Please add min/-1 cases for those two registered overloads as well,
so the new NULL behavior is covered for every signed integer instantiation
touched by the helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
