github-actions[bot] commented on code in PR #15578:
URL: https://github.com/apache/doris/pull/15578#discussion_r1060628495
##########
be/src/olap/rowset/vertical_beta_rowset_writer.h:
##########
@@ -32,7 +32,7 @@ class VerticalBetaRowsetWriter : public BetaRowsetWriter {
bool is_key, uint32_t max_rows_per_segment);
// flush last segment's column
- Status flush_columns();
+ Status flush_columns(bool is_key);
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
Status flush_columns(bool is_key) override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
