github-actions[bot] commented on code in PR #64905:
URL: https://github.com/apache/doris/pull/64905#discussion_r3482396196
##########
be/src/core/column/column_map.h:
##########
@@ -74,15 +73,10 @@ class ColumnMap final : public COWHelper<IColumn,
ColumnMap> {
std::string get_name() const override;
- void for_each_subcolumn(MutableColumnCallback callback) override {
- IColumn::WrappedPtr
offsets(std::move(static_cast<COffsets::Ptr&>(offsets_column)));
- Defer defer([&] {
- static_cast<COffsets::Ptr&>(offsets_column) =
- cast_to_column<COffsets>(static_cast<const
IColumn::Ptr&>(offsets));
- });
- callback(keys_column);
- callback(values_column);
- callback(offsets);
+ void mutate_subcolumns() override {
Review Comment:
This COW refactor changes `ColumnMap` from the old callback/defer path to a
class-specific `mutate_subcolumns()` that must enumerate all three children
(`keys_column`, `values_column`, and typed `offsets_column`). The new tests
cover array and nullable, but there is no focused test that mutates a
shared/exclusive `ColumnMap` and verifies all three child pointers are detached
or preserved correctly. A missed or wrong entry in this method would compile
and leave one map child aliased across mutation, so please add a BE unit test
analogous to the new array/nullable cases for `ColumnMap`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
