github-actions[bot] commented on code in PR #64866:
URL: https://github.com/apache/doris/pull/64866#discussion_r3487509240
##########
be/test/exec/runtime_filter/runtime_filter_mgr_test.cpp:
##########
@@ -103,28 +103,29 @@ TEST_F(RuntimeFilterMgrTest, TestRuntimeFilterMgr) {
.ok());
EXPECT_NE(producer_filter, nullptr);
- LocalMergeContext* local_merge_filters = nullptr;
+ std::shared_ptr<LocalMergeContext> context;
// filter_id not yet registered: global mgr returns OK with nullptr
// (graceful skip for recursive CTE stage reset).
EXPECT_TRUE(global_runtime_filter_mgr
- ->get_local_merge_producer_filters(filter_id,
&local_merge_filters)
+ ->get_local_merge_context(filter_id,
producer_filter->stage(), &context)
Review Comment:
This test still only covers the default stage-0 path:
`producer_filter->stage()` is never changed, and the `PSyncFilterSizeRequest`
below also keeps protobuf stage 0. The production change now relies on nonzero
recursive stages to replace the local merge context and ignore stale-stage
lookups/size syncs, while the recursive CTE regression has
`runtime_filter_mode=off`, so it will not exercise this path. Please add a
focused BE UT that registers a stage-0 producer, then a stage-1 producer for
the same filter, verifies stage-0 `get_local_merge_context`/`sync_filter_size`
are ignored, and verifies the current stage still syncs normally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
