TsukiokaKogane commented on code in PR #64776:
URL: https://github.com/apache/doris/pull/64776#discussion_r3489096330
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTableWrapper.java:
##########
@@ -154,4 +168,15 @@ public MaterializedIndexMeta getBaseIndexMeta() {
public MaterializedIndex getBaseIndex() {
return originTable.getBaseIndex();
}
+
+ public Pair<Long, Long> getPartitionOffset(long partitionId) {
+ return partitionOffsetMap.get(partitionId);
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ return super.equals(obj)
+ && originTable.equals(((OlapTableWrapper) obj).originTable)
+ && partitionOffsetMap.equals(((OlapTableWrapper)
obj).partitionOffsetMap);
Review Comment:
super.equals contains class comparison
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/RowBinlogTableWrapper.java:
##########
@@ -71,12 +67,14 @@ public MaterializedIndex getPartitionIndex(Partition
partition, long indexId) {
return null;
}
- public Optional<OlapTableStreamWrapper> getParent() {
- return parent;
- }
-
@Override
public KeysType getKeysType() {
return KeysType.DUP_KEYS;
}
+
+ @Override
+ public boolean equals(Object obj) {
+ return super.equals(obj)
+ && rowBinlogMeta.equals(((RowBinlogTableWrapper)
obj).rowBinlogMeta);
+ }
Review Comment:
super.equals contains class comparison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
