BiteTheDDDDt commented on code in PR #64899:
URL: https://github.com/apache/doris/pull/64899#discussion_r3489200662
##########
be/src/exec/pipeline/pipeline_task.cpp:
##########
@@ -901,6 +907,9 @@ Status PipelineTask::finalize() {
}
Status PipelineTask::close(Status exec_status, bool close_sink) {
+ if (close_sink) {
Review Comment:
op->close / sink->close 这些东西本质也是写操作，担心会让is blockable这个读操作不安全。而且理论上进close
sink了也不需要再submit了
不过实际执行逻辑是 [close_task] -> [task->close] -> [task->finalize] 。可以只在close
sink里加，finalize里不加
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
