morrySnow commented on code in PR #64849:
URL: https://github.com/apache/doris/pull/64849#discussion_r3489309197
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -675,7 +675,7 @@ public class Rewriter extends AbstractBatchJobExecutor {
cascadesContext ->
cascadesContext.rewritePlanContainsTypes(LogicalAggregate.class)
||
cascadesContext.rewritePlanContainsTypes(LogicalJoin.class)
||
cascadesContext.rewritePlanContainsTypes(LogicalUnion.class),
- topDown(new EliminateGroupByKey()),
+ custom(RuleType.ELIMINATE_GROUP_BY_KEY,
EliminateGroupByKey::new),
Review Comment:
The `ELIMINATE_FILTER_GROUP_BY_KEY` rule type is no longer registered as a
rule after this change. However, it is still defined in `RuleType.java:313` and
referenced in `RelationUtil.java:65` as a disable rule for the sync MV planner.
This means: (1) `ELIMINATE_FILTER_GROUP_BY_KEY` in `RuleType.java` is dead
code, and (2) any session/MV path disabling only
`ELIMINATE_FILTER_GROUP_BY_KEY` silently stops working. Please either keep a
two-rule registration or remove the stale references from `RuleType.java` and
`RelationUtil.java`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
