github-actions[bot] commented on code in PR #63763:
URL: https://github.com/apache/doris/pull/63763#discussion_r3496919590
##########
regression-test/suites/nereids_rules_p0/mv/tpch/mv_tpch_test.groovy:
##########
@@ -226,10 +226,10 @@ suite("mv_tpch_test") {
p_partkey
LIMIT 100;
"""
- // contains limit, doesn't support now
- order_qt_query2_before "${query2}"
- async_mv_rewrite_success(db, mv2, query2, "mv2")
- order_qt_query2_after "${query2}"
+ // contains multi join cluster, not support now
+ // order_qt_query2_before "${query2}"
+ // async_mv_rewrite_success(db, mv2, query2, "mv2")
Review Comment:
The Q2 block should not just be commented out here. In the base suite this
case created `mv2` and `async_mv_rewrite_success(db, mv2, query2, "mv2")`
asserted that the memo plan contained `.mv2 chose`; this patch removes that
assertion and drops the `query2_before`/`query2_after` output sections, so CI
no longer tells us whether the scalar-subquery/window rewrite broke TPCH Q2 MV
rewrite compatibility.
If the new plan shape is supposed to remain supported, please keep this as a
positive `mv2` rewrite check by fixing the rewrite path. If the incompatibility
is intentional, make it an explicit `mv_rewrite_fail`/negative case with the
reason documented instead of leaving the whole case untested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
