github-actions[bot] commented on code in PR #64938: URL: https://github.com/apache/doris/pull/64938#discussion_r3497362912
########## fs_brokers/cdc_client/src/main/java/org/apache/flink/cdc/connectors/postgres/source/fetch/PostgresScanFetchTask.java: ########## @@ -319,7 +323,7 @@ private void createDataEventsForTable( Review Comment: This still does not honor a user-configured snapshot fetch size in Doris. The patched call now uses `sourceConfig.getFetchSize()`, but the Doris config builder only maps `snapshot_split_size`/`snapshot_split_key` before creating the `PostgresSourceConfig`, and there is no `DataSourceConfigKeys` entry or FE validator allow-list entry for a fetch-size property. As a result, a CREATE JOB property like `scan.snapshot.fetch.size` is rejected as an unexpected key, and the client keeps using Flink CDC's default fetch size. Please add a Doris source property for the snapshot fetch size, validate it in the FE/TVF paths, and pass it via `configFactory.fetchSize(...)` so this fix is actually reachable by users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
