deardeng commented on code in PR #64167:
URL: https://github.com/apache/doris/pull/64167#discussion_r3497923236


##########
fe/fe-core/src/main/java/org/apache/doris/persist/meta/MetaPersistMethod.java:
##########
@@ -148,6 +148,14 @@ public static MetaPersistMethod create(String name) throws 
NoSuchMethodException
                         Env.class.getDeclaredMethod("saveColocateTableIndex", 
CountingDataOutputStream.class,
                                 long.class);
                 break;
+            case "tenantLevelColocateTableIndex":

Review Comment:
   After this PR writes VERSION_141 image or tenant-level colocate journals, 
downgrade to VERSION_140 is no longer possible. Is this intended? If yes, 
please document the rollback boundary and upgrade precautions. If not, this PR 
needs a compatibility design, such as gating new metadata writes until the 
feature is enabled or adding downgrade-safe handling.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to