github-actions[bot] commented on code in PR #64944:
URL: https://github.com/apache/doris/pull/64944#discussion_r3498030562
##########
be/src/core/column/column_decimal.cpp:
##########
@@ -237,6 +237,16 @@ void ColumnDecimal<T>::update_crc32c_batch(uint32_t*
__restrict hashes,
}
}
+template <PrimitiveType T>
+void ColumnDecimal<T>::update_crc32c_batch_default_on_null(
Review Comment:
This PR now has two independent implementations behind
`ColumnNullable::update_crc32c_batch_default_on_null`: the vector override and
this decimal override. The new nullable tests only construct
`ColumnInt32`/`ColumnInt64`, so they exercise the vector path, while the
existing decimal CRC tests call `ColumnDecimal::update_crc32c_batch(...,
null_map)` directly, which skips null rows and never verifies this
default-on-null dispatch. Please add a nullable decimal case that builds a
`ColumnNullable(ColumnDecimal...)`, computes the expected hash from a cloned
decimal column after `replace_column_null_data`, and compares it with
`ColumnNullable::update_crc32c_batch`; otherwise a regression in this
decimal-specific branch would still pass the current tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
