Mryange commented on code in PR #65031:
URL: https://github.com/apache/doris/pull/65031#discussion_r3498397759
##########
be/src/exprs/vectorized_agg_fn.h:
##########
@@ -82,11 +82,26 @@ class AggFnEvaluator {
Status streaming_agg_serialize_to_column(Block* block, MutableColumnPtr&
dst,
const size_t num_rows, Arena&
arena);
+ void add_range_single_place(int64_t partition_start, int64_t
partition_end, int64_t frame_start,
+ int64_t frame_end, AggregateDataPtr place,
const IColumn** columns,
+ Arena& arena, UInt8* use_null_result,
+ UInt8* could_use_previous_result);
+
+ void execute_function_with_incremental(int64_t partition_start, int64_t
partition_end,
+ int64_t frame_start, int64_t
frame_end,
+ AggregateDataPtr place, const
IColumn** columns,
+ Arena& arena, bool previous_is_nul,
bool end_is_nul,
+ bool has_null, UInt8*
use_null_result,
+ UInt8* could_use_previous_result);
+
void insert_result_info(AggregateDataPtr place, IColumn* column);
void insert_result_info_vec(const std::vector<AggregateDataPtr>& place,
size_t offset,
IColumn* column, const size_t num_rows);
+ void insert_result_info_range(ConstAggregateDataPtr place, IColumn*
column, size_t start,
+ size_t end);
+
Review Comment:
要不我们直接把
```C++
const AggregateFunctionPtr& function() { return _function; }
```
给删除了？这样就可以保证暴露出去的接口都会被check一下？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
