github-actions[bot] commented on code in PR #65049:
URL: https://github.com/apache/doris/pull/65049#discussion_r3499825896
##########
fe/fe-core/src/main/java/org/apache/doris/load/GroupCommitManager.java:
##########
@@ -370,16 +370,13 @@ private Long getCachedBackend(String cluster, long
tableId) {
}
private boolean isBackendAvailable(Backend backend, String cluster) {
- if (backend == null || !backend.isAlive() ||
backend.isDecommissioned() || !backend.isLoadAvailable()) {
+ if (backend == null || !backend.isAlive() ||
backend.isDecommissioned() || backend.isDecommissioning()
Review Comment:
This new local-mode rejection should also be reflected in the failure
details. After this change, an otherwise alive/load-available backend with
`isDecommissioning()==true` is rejected here, but if all candidates are
rejected the local `backendsInfo` built below still prints only
`decommission=`. That can produce `decommission=false` with no indication of
the actual reason, while the cloud group-commit path already includes both
`decommissioned=` and `decommissioning=`. Please include the `decommissioning`
state in the local diagnostic too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
