morningman commented on code in PR #15622:
URL: https://github.com/apache/doris/pull/15622#discussion_r1061454546
##########
be/src/io/fs/file_reader_options.cpp:
##########
@@ -25,8 +25,8 @@ FileCacheType cache_type_from_string(const std::string& type)
{
return FileCacheType::SUB_FILE_CACHE;
} else if (type == "whole_file_cache") {
return FileCacheType::WHOLE_FILE_CACHE;
- } else if (type == "file_block_cache") {
- return FileCacheType::FILE_BLOCK_CACHE;
+ } else if (type == "remote_file_cache") {
+ return FileCacheType::REMOTE_FILE_CACHE;
Review Comment:
All cache are for `remote file`. So I think the name `REMOTE_FILE_CACHE` can
not indicate which kind of cache it is.
##########
be/src/vec/exec/format/json/new_json_reader.h:
##########
@@ -144,6 +145,9 @@ class NewJsonReader : public GenericReader {
size_t _current_offset;
+ std::unique_ptr<FileCacheStatistics> _file_cache_statistics;
Review Comment:
Why only json reader has `FileCacheStatistics`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
