github-actions[bot] commented on code in PR #65054:
URL: https://github.com/apache/doris/pull/65054#discussion_r3502811710
##########
be/test/exec/executor/time_sharing/time_sharing_task_executor_test.cpp:
##########
@@ -339,6 +340,20 @@ class QueueOnlySplitRunner : public SplitRunner {
std::atomic<bool> _finished {false};
};
Review Comment:
The new test leaves `thread_config.max_thread_num` and
`thread_config.min_thread_num` uninitialized here. `ThreadConfig` only defaults
`max_queue_size`; the constructor copies the two indeterminate ints into
`_max_threads`/`_min_threads`, and `init()` immediately calls
`_try_create_thread(_min_threads, ...)`. That makes this test nondeterministic:
it can try to create an arbitrary number of worker threads or fail depending on
stack contents. Please initialize both fields, like the adjacent tests do,
before constructing the executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
