github-actions[bot] commented on code in PR #64732:
URL: https://github.com/apache/doris/pull/64732#discussion_r3503138290
##########
docker/runtime/README.md:
##########
@@ -59,7 +59,6 @@ amd64(avx2) platform:
| fe | apache-doris-3.0.2-bin-x64/fe |
runtime/fe/resource/amd64/apache-doris-3.0.2-bin-x64/fe
|
| be | apache-doris-3.0.2-bin-x64/be |
runtime/be/resource/amd64/apache-doris-3.0.2-bin-x64/be
|
| ms | apache-doris-3.0.2-bin-x64/ms |
runtime/ms/resource/amd64/apache-doris-3.0.2-bin-x64/ms
|
-| broker | apache-doris-3.0.2-bin-x64/extensions/apache_hdfs_broker |
runtime/broker/resource/amd64/apache-doris-3.0.2-bin-x64/extensions/apache_hdfs_broker
|
Review Comment:
This README cleanup still misses the directory tree near the top of the
file: it continues to list `runtime/broker`, but this PR deletes
`docker/runtime/broker/`. Please remove that tree entry too so the setup
instructions match the post-PR layout.
##########
regression-test/suites/load_p0/broker_load/test_broker_load_with_merge.groovy:
##########
@@ -1,237 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-suite("test_broker_load_with_merge", "load_p0,external") {
Review Comment:
This drops more than just coverage for the removed standalone broker daemon.
The deleted suite also checked load analyzer semantics that the PR says are
still supported in FE/BE, including `DELETE ON` without `MERGE`, `MERGE`
without `DELETE ON`, and `MERGE`/`DELETE` against aggregate tables. After this
deletion, only the `DELETE/MERGE` with `NEGATIVE` error is still asserted
elsewhere (`test_broker_load_with_negtive.groovy`); I could not find remaining
regression coverage for the other error paths. Please keep these cases by
rewriting them to a surviving backend such as `WITH HDFS`/`WITH S3`, as the
existing broker-load suites already do, instead of removing the semantic
coverage with the daemon-specific test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
