github-actions[bot] commented on code in PR #65001:
URL: https://github.com/apache/doris/pull/65001#discussion_r3503692733
##########
docker/runtime/doris-compose/cluster.py:
##########
@@ -862,6 +862,9 @@ def docker_env(self):
time.strftime("%Y%m%d_%H%M%S"),
uuid.uuid4().hex[:8],
)
+ base_prefix = envs.get('DORIS_CLOUD_PREFIX', '').strip().strip('/')
Review Comment:
This only applies the base-prefix rewrite on MS containers, but the
`--external-ms` flow creates the instance from FE-1 instead. In that path
`FE.docker_env()` sets `AUTO_CREATE_INSTANCE=1` and carries the user env
through unchanged, then `init_fe.sh` calls `create_doris_instance`, which sends
`${DORIS_CLOUD_PREFIX}` directly as the storage prefix. So `--env
DORIS_CLOUD_PREFIX=base` works for a normal cloud cluster as
`base/doris_docker_env_...`, but an external-MS cluster stores everything under
just `base`, causing different external-MS clusters that share the same
bucket/base to collide. Please share this prefix composition with the FE
auto-create path, or otherwise ensure the generated per-cluster suffix is
applied before FE-1 creates the instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
