github-actions[bot] commented on code in PR #15597:
URL: https://github.com/apache/doris/pull/15597#discussion_r1062074000
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -574,11 +582,21 @@
std::shared_ptr<io::StreamLoadPipe> FragmentMgr::get_pipe(const TUniqueId&
fragment_instance_id) {
{
std::lock_guard<std::mutex> lock(_lock);
- auto iter = _fragment_map.find(fragment_instance_id);
- if (iter != _fragment_map.end()) {
- return _fragment_map[fragment_instance_id]->get_pipe();
+ auto iter = _pipeline_map.find(fragment_instance_id);
+ if (iter != _pipeline_map.end()) {
+ return _pipeline_map[fragment_instance_id]->get_pipe();
} else {
- return nullptr;
+ iter = _fragment_map.find(fragment_instance_id);
+ if (iter != _fragment_map.end()) {
+ return _fragment_map[fragment_instance_id]->get_pipe();
+ } else {
+ iter = _fragment_map.find(fragment_instance_id);
Review Comment:
warning: no viable overloaded '=' [clang-diagnostic-error]
```cpp
iter = _fragment_map.find(fragment_instance_id);
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:316:** candidate function (the
implicit copy assignment operator) not viable: no known conversion from
'_Node_iterator<pair<[...], shared_ptr<doris::FragmentExecState>>, [2 * ...]>'
to 'const _Node_iterator<pair<[...],
shared_ptr<doris::pipeline::PipelineFragmentContext>>, [2 * ...]>' for 1st
argument
```cpp
struct _Node_iterator
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:316:** candidate function (the
implicit move assignment operator) not viable: no known conversion from
'_Node_iterator<pair<[...], shared_ptr<doris::FragmentExecState>>, [2 * ...]>'
to '_Node_iterator<pair<[...],
shared_ptr<doris::pipeline::PipelineFragmentContext>>, [2 * ...]>' for 1st
argument
```cpp
struct _Node_iterator
^
```
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -574,11 +582,21 @@ void FragmentMgr::set_pipe(const TUniqueId&
fragment_instance_id,
std::shared_ptr<io::StreamLoadPipe> FragmentMgr::get_pipe(const TUniqueId&
fragment_instance_id) {
{
std::lock_guard<std::mutex> lock(_lock);
- auto iter = _fragment_map.find(fragment_instance_id);
- if (iter != _fragment_map.end()) {
- return _fragment_map[fragment_instance_id]->get_pipe();
+ auto iter = _pipeline_map.find(fragment_instance_id);
+ if (iter != _pipeline_map.end()) {
+ return _pipeline_map[fragment_instance_id]->get_pipe();
} else {
- return nullptr;
+ iter = _fragment_map.find(fragment_instance_id);
Review Comment:
warning: no viable overloaded '=' [clang-diagnostic-error]
```cpp
iter = _fragment_map.find(fragment_instance_id);
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:316:** candidate function (the
implicit copy assignment operator) not viable: no known conversion from
'_Node_iterator<pair<[...], shared_ptr<doris::FragmentExecState>>, [2 * ...]>'
to 'const _Node_iterator<pair<[...],
shared_ptr<doris::pipeline::PipelineFragmentContext>>, [2 * ...]>' for 1st
argument
```cpp
struct _Node_iterator
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:316:** candidate function (the
implicit move assignment operator) not viable: no known conversion from
'_Node_iterator<pair<[...], shared_ptr<doris::FragmentExecState>>, [2 * ...]>'
to '_Node_iterator<pair<[...],
shared_ptr<doris::pipeline::PipelineFragmentContext>>, [2 * ...]>' for 1st
argument
```cpp
struct _Node_iterator
^
```
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -574,11 +582,21 @@
std::shared_ptr<io::StreamLoadPipe> FragmentMgr::get_pipe(const TUniqueId&
fragment_instance_id) {
{
std::lock_guard<std::mutex> lock(_lock);
- auto iter = _fragment_map.find(fragment_instance_id);
- if (iter != _fragment_map.end()) {
- return _fragment_map[fragment_instance_id]->get_pipe();
+ auto iter = _pipeline_map.find(fragment_instance_id);
+ if (iter != _pipeline_map.end()) {
+ return _pipeline_map[fragment_instance_id]->get_pipe();
} else {
- return nullptr;
+ iter = _fragment_map.find(fragment_instance_id);
+ if (iter != _fragment_map.end()) {
Review Comment:
warning: invalid operands to binary expression
('std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') and
'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::FragmentExecState>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::FragmentExecState>>, __constant_iterators::value,
__hash_cached::value>')) [clang-diagnostic-error]
```cpp
if (iter != _fragment_map.end()) {
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:308:** candidate function not
viable: no known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const
std::__detail::_Node_iterator_base<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::FragmentExecState>>, true>' for 1st argument
```cpp
operator!=(const _Node_iterator_base& __x, const _Node_iterator_base&
__y)
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:308:** candidate function not
viable: no known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::FragmentExecState>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::FragmentExecState>>, __constant_iterators::value,
__hash_cached::value>') to 'const
std::__detail::_Node_iterator_base<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>, true>' for 2nd
argument
```cpp
operator!=(const _Node_iterator_base& __x, const _Node_iterator_base&
__y)
^
```
**/usr/include/c++/11/system_error:415:** candidate function not viable: no
known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const std::error_code'
for 1st argument
```cpp
operator!=(const error_code& __lhs, const error_code& __rhs) noexcept
^
```
**/usr/include/c++/11/system_error:420:** candidate function not viable: no
known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const std::error_code'
for 1st argument
```cpp
operator!=(const error_code& __lhs, const error_condition& __rhs) noexcept
^
```
**/usr/include/c++/11/system_error:425:** candidate function not viable: no
known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const
std::error_condition' for 1st argument
```cpp
operator!=(const error_condition& __lhs, const error_code& __rhs) noexcept
^
```
**/usr/include/c++/11/system_error:430:** candidate function not viable: no
known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const
std::error_condition' for 1st argument
```cpp
operator!=(const error_condition& __lhs,
^
```
**/usr/include/c++/11/thread:65:** candidate function not viable: no known
conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'thread::id' for 1st
argument
```cpp
operator!=(thread::id __x, thread::id __y) noexcept
^
```
**be/src/util/slice.h:208:** candidate function not viable: no known
conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const doris::Slice'
for 1st argument
```cpp
inline bool operator!=(const Slice& x, const Slice& y) {
^
```
**/usr/include/c++/11/variant:1287:** candidate function not viable: no
known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'std::monostate' for
1st argument
```cpp
constexpr bool operator!=(monostate, monostate) noexcept { return false; }
^
```
**/usr/include/c++/11/bits/stl_pair.h:495:** candidate template ignored:
could not match 'pair' against '_Node_iterator'
```cpp
operator!=(const pair<_T1, _T2>& __x, const pair<_T1, _T2>& __y)
^
```
**/usr/include/c++/11/bits/stl_iterator.h:430:** candidate template ignored:
could not match 'reverse_iterator' against '_Node_iterator'
```cpp
operator!=(const reverse_iterator<_Iterator>& __x,
^
```
**/usr/include/c++/11/bits/stl_iterator.h:469:** candidate template ignored:
could not match 'reverse_iterator' against '_Node_iterator'
```cpp
operator!=(const reverse_iterator<_IteratorL>& __x,
^
```
**/usr/include/c++/11/bits/stl_iterator.h:1549:** candidate template
ignored: could not match 'move_iterator' against '_Node_iterator'
```cpp
operator!=(const move_iterator<_IteratorL>& __x,
^
```
**/usr/include/c++/11/bits/stl_iterator.h:1606:** candidate template
ignored: could not match 'move_iterator' against '_Node_iterator'
```cpp
operator!=(const move_iterator<_Iterator>& __x,
^
```
**/usr/include/c++/11/array:304:** candidate template ignored: could not
match 'array' against '_Node_iterator'
```cpp
operator!=(const array<_Tp, _Nm>& __one, const array<_Tp, _Nm>& __two)
^
```
**/usr/include/c++/11/tuple:1582:** candidate template ignored: could not
match 'tuple' against '_Node_iterator'
```cpp
operator!=(const tuple<_TElements...>& __t,
^
```
**/usr/include/c++/11/bits/std_function.h:736:** candidate template ignored:
could not match 'function' against '_Node_iterator'
```cpp
operator!=(const function<_Res(_Args...)>& __f, nullptr_t) noexcept
^
```
**/usr/include/c++/11/bits/std_function.h:742:** candidate template ignored:
could not match 'function' against '_Node_iterator'
```cpp
operator!=(nullptr_t, const function<_Res(_Args...)>& __f) noexcept
^
```
**/usr/include/c++/11/bits/allocator.h:224:** candidate template ignored:
could not match 'allocator' against '_Node_iterator'
```cpp
operator!=(const allocator<_T1>&, const allocator<_T2>&)
^
```
**/usr/include/c++/11/bits/unordered_map.h:2140:** candidate template
ignored: could not match 'unordered_map' against '_Node_iterator'
```cpp
operator!=(const unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/unordered_map.h:2154:** candidate template
ignored: could not match 'unordered_multimap' against '_Node_iterator'
```cpp
operator!=(const unordered_multimap<_Key, _Tp, _Hash, _Pred, _Alloc>&
__x,
^
```
**/usr/include/c++/11/bits/stl_vector.h:1936:** candidate template ignored:
could not match 'vector' against '_Node_iterator'
```cpp
operator!=(const vector<_Tp, _Alloc>& __x, const vector<_Tp, _Alloc>&
__y)
^
```
**/usr/include/c++/11/bits/unique_ptr.h:773:** candidate template ignored:
could not match 'unique_ptr' against '_Node_iterator'
```cpp
operator!=(const unique_ptr<_Tp, _Dp>& __x,
^
```
**/usr/include/c++/11/bits/unique_ptr.h:780:** candidate template ignored:
could not match 'unique_ptr' against '_Node_iterator'
```cpp
operator!=(const unique_ptr<_Tp, _Dp>& __x, nullptr_t) noexcept
^
```
**/usr/include/c++/11/bits/unique_ptr.h:786:** candidate template ignored:
could not match 'unique_ptr' against '_Node_iterator'
```cpp
operator!=(nullptr_t, const unique_ptr<_Tp, _Dp>& __x) noexcept
^
```
**/usr/include/c++/11/bits/postypes.h:226:** candidate template ignored:
could not match 'fpos' against '_Node_iterator'
```cpp
operator!=(const fpos<_StateT>& __lhs, const fpos<_StateT>& __rhs)
^
```
**/usr/include/c++/11/bits/shared_ptr_base.h:1440:** candidate template
ignored: could not match '__shared_ptr' against '_Node_iterator'
```cpp
operator!=(const __shared_ptr<_Tp1, _Lp>& __a,
^
```
**/usr/include/c++/11/bits/shared_ptr_base.h:1446:** candidate template
ignored: could not match '__shared_ptr' against '_Node_iterator'
```cpp
operator!=(const __shared_ptr<_Tp, _Lp>& __a, nullptr_t) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr_base.h:1451:** candidate template
ignored: could not match '__shared_ptr' against '_Node_iterator'
```cpp
operator!=(nullptr_t, const __shared_ptr<_Tp, _Lp>& __a) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:469:** candidate template ignored:
could not match 'shared_ptr' against '_Node_iterator'
```cpp
operator!=(const shared_ptr<_Tp>& __a, const shared_ptr<_Up>& __b)
noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:475:** candidate template ignored:
could not match 'shared_ptr' against '_Node_iterator'
```cpp
operator!=(const shared_ptr<_Tp>& __a, nullptr_t) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:481:** candidate template ignored:
could not match 'shared_ptr' against '_Node_iterator'
```cpp
operator!=(nullptr_t, const shared_ptr<_Tp>& __a) noexcept
^
```
**/usr/include/c++/11/string_view:569:** candidate template ignored: could
not match 'basic_string_view' against '_Node_iterator'
```cpp
operator!=(basic_string_view<_CharT, _Traits> __x,
^
```
**/usr/include/c++/11/string_view:575:** candidate template ignored: could
not match 'basic_string_view' against '_Node_iterator'
```cpp
operator!=(basic_string_view<_CharT, _Traits> __x,
^
```
**/usr/include/c++/11/string_view:582:** candidate template ignored: could
not match 'basic_string_view' against '_Node_iterator'
```cpp
operator!=(__type_identity_t<basic_string_view<_CharT, _Traits>> __x,
^
```
**/usr/include/c++/11/bits/basic_string.h:6301:** candidate template
ignored: could not match 'basic_string' against '_Node_iterator'
```cpp
operator!=(const basic_string<_CharT, _Traits, _Alloc>& __lhs,
^
```
**/usr/include/c++/11/bits/basic_string.h:6314:** candidate template
ignored: could not match 'const _CharT *' against
'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>')
```cpp
operator!=(const _CharT* __lhs,
^
```
**/usr/include/c++/11/bits/basic_string.h:6326:** candidate template
ignored: could not match 'basic_string' against '_Node_iterator'
```cpp
operator!=(const basic_string<_CharT, _Traits, _Alloc>& __lhs,
^
```
**/usr/include/c++/11/bits/streambuf_iterator.h:231:** candidate template
ignored: could not match 'istreambuf_iterator' against '_Node_iterator'
```cpp
operator!=(const istreambuf_iterator<_CharT, _Traits>& __a,
^
```
**/usr/include/c++/11/bits/stl_map.h:1507:** candidate template ignored:
could not match 'map' against '_Node_iterator'
```cpp
operator!=(const map<_Key, _Tp, _Compare, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/stl_multimap.h:1172:** candidate template
ignored: could not match 'multimap' against '_Node_iterator'
```cpp
operator!=(const multimap<_Key, _Tp, _Compare, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/stl_list.h:2056:** candidate template ignored:
could not match 'list' against '_Node_iterator'
```cpp
operator!=(const list<_Tp, _Alloc>& __x, const list<_Tp, _Alloc>& __y)
^
```
**/usr/include/c++/11/bits/stl_set.h:1029:** candidate template ignored:
could not match 'set' against '_Node_iterator'
```cpp
operator!=(const set<_Key, _Compare, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/stl_multiset.h:1015:** candidate template
ignored: could not match 'multiset' against '_Node_iterator'
```cpp
operator!=(const multiset<_Key, _Compare, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/unordered_set.h:1810:** candidate template
ignored: could not match 'unordered_set' against '_Node_iterator'
```cpp
operator!=(const unordered_set<_Value, _Hash, _Pred, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/unordered_set.h:1824:** candidate template
ignored: could not match 'unordered_multiset' against '_Node_iterator'
```cpp
operator!=(const unordered_multiset<_Value, _Hash, _Pred, _Alloc>& __x,
^
```
**/usr/include/c++/11/optional:1053:** candidate template ignored: could not
match 'optional' against '_Node_iterator'
```cpp
operator!=(const optional<_Tp>& __lhs, const optional<_Up>& __rhs)
^
```
**/usr/include/c++/11/optional:1120:** candidate template ignored: could not
match 'optional' against '_Node_iterator'
```cpp
operator!=(const optional<_Tp>& __lhs, nullopt_t) noexcept
^
```
**/usr/include/c++/11/optional:1125:** candidate template ignored: could not
match 'optional' against '_Node_iterator'
```cpp
operator!=(nullopt_t, const optional<_Tp>& __rhs) noexcept
^
```
**/usr/include/c++/11/optional:1184:** candidate template ignored: could not
match 'optional' against '_Node_iterator'
```cpp
operator!=(const optional<_Tp>& __lhs, const _Up& __rhs)
^
```
**/usr/include/c++/11/optional:1190:** candidate template ignored: could not
match 'optional' against '_Node_iterator'
```cpp
operator!=(const _Up& __lhs, const optional<_Tp>& __rhs)
^
```
**/usr/include/c++/11/bits/stl_deque.h:2290:** candidate template ignored:
could not match 'deque' against '_Node_iterator'
```cpp
operator!=(const deque<_Tp, _Alloc>& __x, const deque<_Tp, _Alloc>& __y)
^
```
**/usr/include/c++/11/variant:1249:** candidate template ignored: could not
match 'variant' against '_Node_iterator'
```cpp
_VARIANT_RELATION_FUNCTION_TEMPLATE(!=, not_equal)
^
```
**/usr/include/c++/11/variant:1223:** expanded from macro
'_VARIANT_RELATION_FUNCTION_TEMPLATE'
```cpp
constexpr bool operator __OP(const variant<_Types...>& __lhs, \
^
```
**/usr/include/c++/11/complex:482:** candidate template ignored: could not
match 'complex' against '_Node_iterator'
```cpp
operator!=(const complex<_Tp>& __x, const complex<_Tp>& __y)
^
```
**/usr/include/c++/11/complex:487:** candidate template ignored: could not
match 'complex' against '_Node_iterator'
```cpp
operator!=(const complex<_Tp>& __x, const _Tp& __y)
^
```
**/usr/include/c++/11/complex:492:** candidate template ignored: could not
match 'complex' against '_Node_iterator'
```cpp
operator!=(const _Tp& __x, const complex<_Tp>& __y)
^
```
**/usr/include/c++/11/bits/stl_stack.h:342:** candidate template ignored:
could not match 'stack' against '_Node_iterator'
```cpp
operator!=(const stack<_Tp, _Seq>& __x, const stack<_Tp, _Seq>& __y)
^
```
**/usr/include/c++/11/bits/regex.h:1065:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(const sub_match<_BiIter>& __lhs, const sub_match<_BiIter>&
__rhs)
^
```
**/usr/include/c++/11/bits/regex.h:1145:** candidate template ignored: could
not match 'basic_string' against '_Node_iterator'
```cpp
operator!=(const __sub_match_string<_Bi_iter, _Ch_traits, _Ch_alloc>&
__lhs,
^
```
**/usr/include/c++/11/bits/regex.h:1238:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(const sub_match<_Bi_iter>& __lhs,
^
```
**/usr/include/c++/11/bits/regex.h:1312:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(typename iterator_traits<_Bi_iter>::value_type const* __lhs,
^
```
**/usr/include/c++/11/bits/regex.h:1406:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(const sub_match<_Bi_iter>& __lhs,
^
```
**/usr/include/c++/11/bits/regex.h:1480:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(typename iterator_traits<_Bi_iter>::value_type const& __lhs,
^
```
**/usr/include/c++/11/bits/regex.h:1580:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(const sub_match<_Bi_iter>& __lhs,
^
```
**/usr/include/c++/11/bits/regex.h:2127:** candidate template ignored: could
not match 'match_results' against '_Node_iterator'
```cpp
operator!=(const match_results<_Bi_iter, _Alloc>& __m1,
^
```
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -574,11 +582,21 @@
std::shared_ptr<io::StreamLoadPipe> FragmentMgr::get_pipe(const TUniqueId&
fragment_instance_id) {
{
std::lock_guard<std::mutex> lock(_lock);
- auto iter = _fragment_map.find(fragment_instance_id);
- if (iter != _fragment_map.end()) {
- return _fragment_map[fragment_instance_id]->get_pipe();
+ auto iter = _pipeline_map.find(fragment_instance_id);
+ if (iter != _pipeline_map.end()) {
+ return _pipeline_map[fragment_instance_id]->get_pipe();
} else {
- return nullptr;
+ iter = _fragment_map.find(fragment_instance_id);
+ if (iter != _fragment_map.end()) {
+ return _fragment_map[fragment_instance_id]->get_pipe();
+ } else {
+ iter = _fragment_map.find(fragment_instance_id);
+ if (iter != _fragment_map.end()) {
Review Comment:
warning: invalid operands to binary expression
('std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') and
'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::FragmentExecState>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::FragmentExecState>>, __constant_iterators::value,
__hash_cached::value>')) [clang-diagnostic-error]
```cpp
if (iter != _fragment_map.end()) {
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:308:** candidate function not
viable: no known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const
std::__detail::_Node_iterator_base<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::FragmentExecState>>, true>' for 1st argument
```cpp
operator!=(const _Node_iterator_base& __x, const _Node_iterator_base&
__y)
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:308:** candidate function not
viable: no known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::FragmentExecState>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::FragmentExecState>>, __constant_iterators::value,
__hash_cached::value>') to 'const
std::__detail::_Node_iterator_base<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>, true>' for 2nd
argument
```cpp
operator!=(const _Node_iterator_base& __x, const _Node_iterator_base&
__y)
^
```
**/usr/include/c++/11/system_error:415:** candidate function not viable: no
known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const std::error_code'
for 1st argument
```cpp
operator!=(const error_code& __lhs, const error_code& __rhs) noexcept
^
```
**/usr/include/c++/11/system_error:420:** candidate function not viable: no
known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const std::error_code'
for 1st argument
```cpp
operator!=(const error_code& __lhs, const error_condition& __rhs) noexcept
^
```
**/usr/include/c++/11/system_error:425:** candidate function not viable: no
known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const
std::error_condition' for 1st argument
```cpp
operator!=(const error_condition& __lhs, const error_code& __rhs) noexcept
^
```
**/usr/include/c++/11/system_error:430:** candidate function not viable: no
known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const
std::error_condition' for 1st argument
```cpp
operator!=(const error_condition& __lhs,
^
```
**/usr/include/c++/11/thread:65:** candidate function not viable: no known
conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'thread::id' for 1st
argument
```cpp
operator!=(thread::id __x, thread::id __y) noexcept
^
```
**be/src/util/slice.h:208:** candidate function not viable: no known
conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'const doris::Slice'
for 1st argument
```cpp
inline bool operator!=(const Slice& x, const Slice& y) {
^
```
**/usr/include/c++/11/variant:1287:** candidate function not viable: no
known conversion from 'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>') to 'std::monostate' for
1st argument
```cpp
constexpr bool operator!=(monostate, monostate) noexcept { return false; }
^
```
**/usr/include/c++/11/bits/stl_pair.h:495:** candidate template ignored:
could not match 'pair' against '_Node_iterator'
```cpp
operator!=(const pair<_T1, _T2>& __x, const pair<_T1, _T2>& __y)
^
```
**/usr/include/c++/11/bits/stl_iterator.h:430:** candidate template ignored:
could not match 'reverse_iterator' against '_Node_iterator'
```cpp
operator!=(const reverse_iterator<_Iterator>& __x,
^
```
**/usr/include/c++/11/bits/stl_iterator.h:469:** candidate template ignored:
could not match 'reverse_iterator' against '_Node_iterator'
```cpp
operator!=(const reverse_iterator<_IteratorL>& __x,
^
```
**/usr/include/c++/11/bits/stl_iterator.h:1549:** candidate template
ignored: could not match 'move_iterator' against '_Node_iterator'
```cpp
operator!=(const move_iterator<_IteratorL>& __x,
^
```
**/usr/include/c++/11/bits/stl_iterator.h:1606:** candidate template
ignored: could not match 'move_iterator' against '_Node_iterator'
```cpp
operator!=(const move_iterator<_Iterator>& __x,
^
```
**/usr/include/c++/11/array:304:** candidate template ignored: could not
match 'array' against '_Node_iterator'
```cpp
operator!=(const array<_Tp, _Nm>& __one, const array<_Tp, _Nm>& __two)
^
```
**/usr/include/c++/11/tuple:1582:** candidate template ignored: could not
match 'tuple' against '_Node_iterator'
```cpp
operator!=(const tuple<_TElements...>& __t,
^
```
**/usr/include/c++/11/bits/std_function.h:736:** candidate template ignored:
could not match 'function' against '_Node_iterator'
```cpp
operator!=(const function<_Res(_Args...)>& __f, nullptr_t) noexcept
^
```
**/usr/include/c++/11/bits/std_function.h:742:** candidate template ignored:
could not match 'function' against '_Node_iterator'
```cpp
operator!=(nullptr_t, const function<_Res(_Args...)>& __f) noexcept
^
```
**/usr/include/c++/11/bits/allocator.h:224:** candidate template ignored:
could not match 'allocator' against '_Node_iterator'
```cpp
operator!=(const allocator<_T1>&, const allocator<_T2>&)
^
```
**/usr/include/c++/11/bits/unordered_map.h:2140:** candidate template
ignored: could not match 'unordered_map' against '_Node_iterator'
```cpp
operator!=(const unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/unordered_map.h:2154:** candidate template
ignored: could not match 'unordered_multimap' against '_Node_iterator'
```cpp
operator!=(const unordered_multimap<_Key, _Tp, _Hash, _Pred, _Alloc>&
__x,
^
```
**/usr/include/c++/11/bits/stl_vector.h:1936:** candidate template ignored:
could not match 'vector' against '_Node_iterator'
```cpp
operator!=(const vector<_Tp, _Alloc>& __x, const vector<_Tp, _Alloc>&
__y)
^
```
**/usr/include/c++/11/bits/unique_ptr.h:773:** candidate template ignored:
could not match 'unique_ptr' against '_Node_iterator'
```cpp
operator!=(const unique_ptr<_Tp, _Dp>& __x,
^
```
**/usr/include/c++/11/bits/unique_ptr.h:780:** candidate template ignored:
could not match 'unique_ptr' against '_Node_iterator'
```cpp
operator!=(const unique_ptr<_Tp, _Dp>& __x, nullptr_t) noexcept
^
```
**/usr/include/c++/11/bits/unique_ptr.h:786:** candidate template ignored:
could not match 'unique_ptr' against '_Node_iterator'
```cpp
operator!=(nullptr_t, const unique_ptr<_Tp, _Dp>& __x) noexcept
^
```
**/usr/include/c++/11/bits/postypes.h:226:** candidate template ignored:
could not match 'fpos' against '_Node_iterator'
```cpp
operator!=(const fpos<_StateT>& __lhs, const fpos<_StateT>& __rhs)
^
```
**/usr/include/c++/11/bits/shared_ptr_base.h:1440:** candidate template
ignored: could not match '__shared_ptr' against '_Node_iterator'
```cpp
operator!=(const __shared_ptr<_Tp1, _Lp>& __a,
^
```
**/usr/include/c++/11/bits/shared_ptr_base.h:1446:** candidate template
ignored: could not match '__shared_ptr' against '_Node_iterator'
```cpp
operator!=(const __shared_ptr<_Tp, _Lp>& __a, nullptr_t) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr_base.h:1451:** candidate template
ignored: could not match '__shared_ptr' against '_Node_iterator'
```cpp
operator!=(nullptr_t, const __shared_ptr<_Tp, _Lp>& __a) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:469:** candidate template ignored:
could not match 'shared_ptr' against '_Node_iterator'
```cpp
operator!=(const shared_ptr<_Tp>& __a, const shared_ptr<_Up>& __b)
noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:475:** candidate template ignored:
could not match 'shared_ptr' against '_Node_iterator'
```cpp
operator!=(const shared_ptr<_Tp>& __a, nullptr_t) noexcept
^
```
**/usr/include/c++/11/bits/shared_ptr.h:481:** candidate template ignored:
could not match 'shared_ptr' against '_Node_iterator'
```cpp
operator!=(nullptr_t, const shared_ptr<_Tp>& __a) noexcept
^
```
**/usr/include/c++/11/string_view:569:** candidate template ignored: could
not match 'basic_string_view' against '_Node_iterator'
```cpp
operator!=(basic_string_view<_CharT, _Traits> __x,
^
```
**/usr/include/c++/11/string_view:575:** candidate template ignored: could
not match 'basic_string_view' against '_Node_iterator'
```cpp
operator!=(basic_string_view<_CharT, _Traits> __x,
^
```
**/usr/include/c++/11/string_view:582:** candidate template ignored: could
not match 'basic_string_view' against '_Node_iterator'
```cpp
operator!=(__type_identity_t<basic_string_view<_CharT, _Traits>> __x,
^
```
**/usr/include/c++/11/bits/basic_string.h:6301:** candidate template
ignored: could not match 'basic_string' against '_Node_iterator'
```cpp
operator!=(const basic_string<_CharT, _Traits, _Alloc>& __lhs,
^
```
**/usr/include/c++/11/bits/basic_string.h:6314:** candidate template
ignored: could not match 'const _CharT *' against
'std::unordered_map<doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>::iterator' (aka
'_Node_iterator<std::pair<const doris::TUniqueId,
std::shared_ptr<doris::pipeline::PipelineFragmentContext>>,
__constant_iterators::value, __hash_cached::value>')
```cpp
operator!=(const _CharT* __lhs,
^
```
**/usr/include/c++/11/bits/basic_string.h:6326:** candidate template
ignored: could not match 'basic_string' against '_Node_iterator'
```cpp
operator!=(const basic_string<_CharT, _Traits, _Alloc>& __lhs,
^
```
**/usr/include/c++/11/bits/streambuf_iterator.h:231:** candidate template
ignored: could not match 'istreambuf_iterator' against '_Node_iterator'
```cpp
operator!=(const istreambuf_iterator<_CharT, _Traits>& __a,
^
```
**/usr/include/c++/11/bits/stl_map.h:1507:** candidate template ignored:
could not match 'map' against '_Node_iterator'
```cpp
operator!=(const map<_Key, _Tp, _Compare, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/stl_multimap.h:1172:** candidate template
ignored: could not match 'multimap' against '_Node_iterator'
```cpp
operator!=(const multimap<_Key, _Tp, _Compare, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/stl_list.h:2056:** candidate template ignored:
could not match 'list' against '_Node_iterator'
```cpp
operator!=(const list<_Tp, _Alloc>& __x, const list<_Tp, _Alloc>& __y)
^
```
**/usr/include/c++/11/bits/stl_set.h:1029:** candidate template ignored:
could not match 'set' against '_Node_iterator'
```cpp
operator!=(const set<_Key, _Compare, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/stl_multiset.h:1015:** candidate template
ignored: could not match 'multiset' against '_Node_iterator'
```cpp
operator!=(const multiset<_Key, _Compare, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/unordered_set.h:1810:** candidate template
ignored: could not match 'unordered_set' against '_Node_iterator'
```cpp
operator!=(const unordered_set<_Value, _Hash, _Pred, _Alloc>& __x,
^
```
**/usr/include/c++/11/bits/unordered_set.h:1824:** candidate template
ignored: could not match 'unordered_multiset' against '_Node_iterator'
```cpp
operator!=(const unordered_multiset<_Value, _Hash, _Pred, _Alloc>& __x,
^
```
**/usr/include/c++/11/optional:1053:** candidate template ignored: could not
match 'optional' against '_Node_iterator'
```cpp
operator!=(const optional<_Tp>& __lhs, const optional<_Up>& __rhs)
^
```
**/usr/include/c++/11/optional:1120:** candidate template ignored: could not
match 'optional' against '_Node_iterator'
```cpp
operator!=(const optional<_Tp>& __lhs, nullopt_t) noexcept
^
```
**/usr/include/c++/11/optional:1125:** candidate template ignored: could not
match 'optional' against '_Node_iterator'
```cpp
operator!=(nullopt_t, const optional<_Tp>& __rhs) noexcept
^
```
**/usr/include/c++/11/optional:1184:** candidate template ignored: could not
match 'optional' against '_Node_iterator'
```cpp
operator!=(const optional<_Tp>& __lhs, const _Up& __rhs)
^
```
**/usr/include/c++/11/optional:1190:** candidate template ignored: could not
match 'optional' against '_Node_iterator'
```cpp
operator!=(const _Up& __lhs, const optional<_Tp>& __rhs)
^
```
**/usr/include/c++/11/bits/stl_deque.h:2290:** candidate template ignored:
could not match 'deque' against '_Node_iterator'
```cpp
operator!=(const deque<_Tp, _Alloc>& __x, const deque<_Tp, _Alloc>& __y)
^
```
**/usr/include/c++/11/variant:1249:** candidate template ignored: could not
match 'variant' against '_Node_iterator'
```cpp
_VARIANT_RELATION_FUNCTION_TEMPLATE(!=, not_equal)
^
```
**/usr/include/c++/11/variant:1223:** expanded from macro
'_VARIANT_RELATION_FUNCTION_TEMPLATE'
```cpp
constexpr bool operator __OP(const variant<_Types...>& __lhs, \
^
```
**/usr/include/c++/11/complex:482:** candidate template ignored: could not
match 'complex' against '_Node_iterator'
```cpp
operator!=(const complex<_Tp>& __x, const complex<_Tp>& __y)
^
```
**/usr/include/c++/11/complex:487:** candidate template ignored: could not
match 'complex' against '_Node_iterator'
```cpp
operator!=(const complex<_Tp>& __x, const _Tp& __y)
^
```
**/usr/include/c++/11/complex:492:** candidate template ignored: could not
match 'complex' against '_Node_iterator'
```cpp
operator!=(const _Tp& __x, const complex<_Tp>& __y)
^
```
**/usr/include/c++/11/bits/stl_stack.h:342:** candidate template ignored:
could not match 'stack' against '_Node_iterator'
```cpp
operator!=(const stack<_Tp, _Seq>& __x, const stack<_Tp, _Seq>& __y)
^
```
**/usr/include/c++/11/bits/regex.h:1065:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(const sub_match<_BiIter>& __lhs, const sub_match<_BiIter>&
__rhs)
^
```
**/usr/include/c++/11/bits/regex.h:1145:** candidate template ignored: could
not match 'basic_string' against '_Node_iterator'
```cpp
operator!=(const __sub_match_string<_Bi_iter, _Ch_traits, _Ch_alloc>&
__lhs,
^
```
**/usr/include/c++/11/bits/regex.h:1238:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(const sub_match<_Bi_iter>& __lhs,
^
```
**/usr/include/c++/11/bits/regex.h:1312:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(typename iterator_traits<_Bi_iter>::value_type const* __lhs,
^
```
**/usr/include/c++/11/bits/regex.h:1406:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(const sub_match<_Bi_iter>& __lhs,
^
```
**/usr/include/c++/11/bits/regex.h:1480:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(typename iterator_traits<_Bi_iter>::value_type const& __lhs,
^
```
**/usr/include/c++/11/bits/regex.h:1580:** candidate template ignored: could
not match 'sub_match' against '_Node_iterator'
```cpp
operator!=(const sub_match<_Bi_iter>& __lhs,
^
```
**/usr/include/c++/11/bits/regex.h:2127:** candidate template ignored: could
not match 'match_results' against '_Node_iterator'
```cpp
operator!=(const match_results<_Bi_iter, _Alloc>& __m1,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
