HappenLee commented on code in PR #64851:
URL: https://github.com/apache/doris/pull/64851#discussion_r3503788011
##########
be/src/exec/runtime_filter/runtime_filter_mgr.cpp:
##########
@@ -48,6 +51,189 @@
namespace doris {
+namespace {
+
+std::vector<RuntimeFilterPublishTarget> build_runtime_filter_publish_targets(
+ const std::vector<TRuntimeFilterTargetParamsV2>& targets) {
+ std::vector<RuntimeFilterPublishTarget> publish_targets;
+ publish_targets.reserve(targets.size());
+ for (const auto& target : targets) {
+ DORIS_CHECK(target.__isset.target_fragment_ids);
+ DORIS_CHECK(!target.target_fragment_ids.empty());
+ RuntimeFilterPublishTarget publish_target;
+
publish_target.addr.set_hostname(target.target_fragment_instance_addr.hostname);
+
publish_target.addr.set_port(target.target_fragment_instance_addr.port);
+ publish_target.fragment_ids = target.target_fragment_ids;
+ publish_targets.emplace_back(std::move(publish_target));
+ }
+ return publish_targets;
+}
+
+class RuntimeFilterRelayRpcClosure final : public google::protobuf::Closure {
+public:
+ RuntimeFilterRelayRpcClosure(std::shared_ptr<PPublishFilterRequestV2>
request,
+ std::weak_ptr<QueryContext> query_ctx)
+ : _request(std::move(request)),
+
_callback(HandleErrorBrpcCallback<PPublishFilterResponse>::create_shared(
+ std::move(query_ctx))) {}
+
+ void Run() override {
+ std::unique_ptr<RuntimeFilterRelayRpcClosure> self(this);
+ _callback->call();
+ }
+
+ brpc::Controller* cntl() { return _callback->cntl_.get(); }
+ PPublishFilterRequestV2* request() { return _request.get(); }
+ PPublishFilterResponse* response() { return _callback->response_.get(); }
+
+private:
+ std::shared_ptr<PPublishFilterRequestV2> _request;
+ std::shared_ptr<HandleErrorBrpcCallback<PPublishFilterResponse>> _callback;
+};
+
+Status send_runtime_filter_relay_rpc(const RuntimeFilterPublishTask& task,
+ const butil::IOBuf& request_attachment,
int timeout_ms,
+ std::weak_ptr<QueryContext> query_ctx) {
+ std::shared_ptr<PBackendService_Stub> stub(
+
ExecEnv::GetInstance()->brpc_internal_client_cache()->get_client(task.receiver.addr));
+ if (stub == nullptr) {
+ LOG(WARNING) << "Failed to init runtime filter relay rpc to "
+ << task.receiver.addr.hostname() << ":" <<
task.receiver.addr.port();
+ return Status::InternalError("Failed to init runtime filter relay rpc
to {}:{}",
+ task.receiver.addr.hostname(),
task.receiver.addr.port());
+ }
+
+ // brpc calls Run() exactly once; RuntimeFilterRelayRpcClosure deletes
itself there.
+ auto* closure = new RuntimeFilterRelayRpcClosure(
+ std::make_shared<PPublishFilterRequestV2>(task.request),
std::move(query_ctx));
+ if (request_attachment.size() > 0) {
+ closure->cntl()->request_attachment().append(request_attachment);
+ }
+ closure->cntl()->set_timeout_ms(timeout_ms);
+ if (config::execution_ignore_eovercrowded) {
+ closure->cntl()->ignore_eovercrowded();
+ }
+ stub->apply_filterv2(closure->cntl(), closure->request(),
closure->response(), closure);
+ return Status::OK();
+}
+
+void set_request_direct_publish_target(const TRuntimeFilterTargetParamsV2&
target,
+ PPublishFilterRequestV2* request) {
+ DORIS_CHECK(target.__isset.target_fragment_ids);
+ DORIS_CHECK(!target.target_fragment_ids.empty());
+ for (const auto& target_fragment_id : target.target_fragment_ids) {
+ request->add_fragment_ids(target_fragment_id);
+ }
+}
+
+} // namespace
+
+std::vector<std::vector<RuntimeFilterPublishTarget>>
split_runtime_filter_publish_targets(
+ const std::vector<RuntimeFilterPublishTarget>& targets, int fanout) {
+ DORIS_CHECK(!targets.empty());
+ DORIS_CHECK(fanout > 0);
+ size_t slice_count = std::min(targets.size(), static_cast<size_t>(fanout));
+ std::vector<std::vector<RuntimeFilterPublishTarget>> slices;
+ slices.reserve(slice_count);
+ for (size_t offset = 0; offset < targets.size();) {
+ size_t remaining_targets = targets.size() - offset;
+ size_t remaining_slices = slice_count - slices.size();
+ size_t slice_size = (remaining_targets + remaining_slices - 1) /
remaining_slices;
+ slices.emplace_back(targets.begin() + offset, targets.begin() + offset
+ slice_size);
+ offset += slice_size;
+ }
+ return slices;
+}
+
+std::vector<RuntimeFilterPublishTask> build_runtime_filter_publish_tasks(
+ const PPublishFilterRequestV2& base_request,
+ const std::vector<RuntimeFilterPublishTarget>& targets, int fanout) {
+ std::vector<RuntimeFilterPublishTask> tasks;
+ auto slices = split_runtime_filter_publish_targets(targets, fanout);
+ PPublishFilterRequestV2 request_template = base_request;
+ request_template.clear_fragment_ids();
+ request_template.clear_fragment_instance_ids();
+ request_template.clear_forward_targets();
+ tasks.reserve(slices.size());
+ for (const auto& slice : slices) {
+ DORIS_CHECK(!slice.empty());
+ RuntimeFilterPublishTask task;
+ task.receiver = slice.front();
+ task.request = request_template;
+
+ for (int32_t fragment_id : task.receiver.fragment_ids) {
+ task.request.add_fragment_ids(fragment_id);
+ }
+ for (size_t i = 1; i < slice.size(); ++i) {
+ DORIS_CHECK(!slice[i].fragment_ids.empty());
+ PPublishFilterForwardTarget* forward_target =
task.request.add_forward_targets();
+ forward_target->mutable_target_addr()->CopyFrom(slice[i].addr);
+ for (int32_t fragment_id : slice[i].fragment_ids) {
+ forward_target->add_fragment_ids(fragment_id);
+ }
+ }
+ tasks.emplace_back(std::move(task));
+ }
+ return tasks;
+}
+
+int calculate_tree_publish_fanout(int64_t serialized_filter_size, size_t
target_count,
+ int64_t max_send_bytes) {
+ DORIS_CHECK(serialized_filter_size > 0);
+ DORIS_CHECK(max_send_bytes >= 0);
+ if (max_send_bytes == 0 || target_count <= 1) {
+ return 0;
+ }
+
+ const int64_t direct_target_limit = max_send_bytes /
serialized_filter_size;
+ if (target_count <= static_cast<size_t>(direct_target_limit)) {
+ return 0;
+ }
+
+ int64_t fanout = std::max<int64_t>(1, direct_target_limit);
+ fanout = std::min<int64_t>(fanout, static_cast<int64_t>(target_count - 1));
+ return static_cast<int>(fanout);
+}
+
+Status forward_runtime_filter(const PPublishFilterRequestV2& request,
+ const butil::IOBuf& request_attachment,
+ std::weak_ptr<QueryContext> query_ctx) {
+ if (request.forward_targets().empty()) {
+ return Status::OK();
+ }
+
+ std::vector<RuntimeFilterPublishTarget> targets;
+ targets.reserve(request.forward_targets_size());
+ for (const auto& forward_target : request.forward_targets()) {
+ DORIS_CHECK(forward_target.has_target_addr());
+ DORIS_CHECK(forward_target.fragment_ids_size() > 0);
+ RuntimeFilterPublishTarget target;
+ target.addr.CopyFrom(forward_target.target_addr());
+ target.fragment_ids.assign(forward_target.fragment_ids().begin(),
+ forward_target.fragment_ids().end());
+ targets.emplace_back(std::move(target));
+ }
+
+ DORIS_CHECK(request.has_tree_publish_fanout());
+ int fanout = request.tree_publish_fanout();
+ DORIS_CHECK(fanout > 0);
+ DORIS_CHECK(request.has_publish_rpc_timeout_ms());
+ int timeout_ms = request.publish_rpc_timeout_ms();
+ auto tasks = build_runtime_filter_publish_tasks(request, targets, fanout);
+ VLOG_NOTICE << "Runtime filter relay publish filter_id=" <<
request.filter_id()
+ << ", forward_targets=" << targets.size() << ",
child_rpc_count=" << tasks.size()
+ << ", fanout=" << fanout;
+ auto st = Status::OK();
+ for (const auto& task : tasks) {
+ Status rpc_st =
+ send_runtime_filter_relay_rpc(task, request_attachment,
timeout_ms, query_ctx);
+ if (!rpc_st.ok()) {
Review Comment:
这里是不是可以加个日志打印啊，这样能够知道说哪些节点都发失败。如果存在多个失败的情况下.forward的时候得打印了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
