yiguolei commented on code in PR #64776:
URL: https://github.com/apache/doris/pull/64776#discussion_r3503973837
##########
be/src/storage/segment/segment.cpp:
##########
@@ -279,7 +279,16 @@ Status Segment::new_iterator(SchemaSPtr schema, const
StorageReadOptions& read_o
}
const TabletColumn& col =
read_options.tablet_schema->column(column_id);
std::shared_ptr<ColumnReader> reader;
- Status st = get_column_reader(col, &reader, read_options.stats);
+ // __DORIS_COMMIT_TSO_COL__ on a single-version segment stores a 0
placeholder on disk
Review Comment:
1. 这里把原来segment iterator 里的比如default value iterator，version 之类的，都统一处理了吧。
2. 如果这里有了const column iterator了，segment iterator 里那堆if else 是不是就不需要了？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
