github-actions[bot] commented on code in PR #65113:
URL: https://github.com/apache/doris/pull/65113#discussion_r3505250077
##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -536,10 +529,6 @@ struct TRuntimeFilterParams {
// Runtime filter merge instance address. Used if this filter has a remote
target
1: optional Types.TNetworkAddress runtime_filter_merge_addr
- // keep 2/3/4/5 unset if BE is not used for merge
- // deprecated
Review Comment:
`TRuntimeFilterParams` is still a live FE/BE wire struct, so after deleting
the deprecated field it would be safer to leave field id 2 explicitly reserved
here, e.g. `// 2 reserved/deprecated: rid_to_target_param
(TRuntimeFilterTargetParams); do not reuse`. Current mixed-version traffic can
skip the unknown old field, but with no marker this id now looks available; a
later reuse of field 2 could be decoded by older Doris binaries as the old
`rid_to_target_param` map during rolling upgrade/cross-branch operation. This
file already preserves similar thrift ids with `reserved_field_*`
placeholders/comments in other service structs, so please keep the retired id
visible even though the generated struct field is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
