github-actions[bot] commented on code in PR #64071:
URL: https://github.com/apache/doris/pull/64071#discussion_r3505829646
##########
fe/fe-core/src/test/java/org/apache/doris/load/routineload/RoutineLoadJobTest.java:
##########
@@ -336,6 +337,81 @@ public void testGetShowCreateInfo() throws UserException {
Assert.assertEquals(expect, showCreateInfo);
}
+ @Test
+ public void testGetShowCreateInfoWithFillMissingColumns() throws
UserException {
+ KafkaRoutineLoadJob routineLoadJob = new KafkaRoutineLoadJob(111L,
"test_load", 1,
+ 11, "localhost:9092", "test_topic", UserIdentity.ADMIN);
+ Deencapsulation.setField(routineLoadJob, "maxErrorNum", 10);
+ Deencapsulation.setField(routineLoadJob, "maxBatchRows", 10);
+
+ // Set fill_missing_columns to true
+ Map<String, String> jobProperties = Maps.newHashMap();
+
jobProperties.put(org.apache.doris.datasource.property.fileformat.JsonFileFormatProperties.PROP_FILL_MISSING_COLUMNS,
"true");
Review Comment:
FE checkstyle enforces `LineLength` with `max=120` for Java files, but this
newly added line is 134 columns. Please wrap the property constant or import
`JsonFileFormatProperties` here before FE checkstyle runs.
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/AlterRoutineLoadCommandTest.java:
##########
@@ -114,5 +116,34 @@ public void testValidate() {
Assertions.assertTrue(command.getAnalyzedJobProperties().containsKey(CreateRoutineLoadInfo.MAX_BATCH_SIZE_PROPERTY));
Assertions.assertTrue(command.getAnalyzedJobProperties().containsKey(CreateRoutineLoadInfo.STRICT_MODE));
Assertions.assertTrue(command.getAnalyzedJobProperties().containsKey(CreateRoutineLoadInfo.TIMEZONE));
+
Assertions.assertTrue(command.getAnalyzedJobProperties().containsKey(JsonFileFormatProperties.PROP_FILL_MISSING_COLUMNS));
Review Comment:
These new `fill_missing_columns` test additions exceed the FE checkstyle
120-column limit; this line is 130 columns and several added lines in the two
new test cases below also exceed the limit. Please wrap the chained
calls/constructor arguments before FE checkstyle runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
