github-actions[bot] commented on code in PR #63621:
URL: https://github.com/apache/doris/pull/63621#discussion_r3510466486
##########
regression-test/suites/datatype_p0/complex_types/test_complex_disallowed_subtypes.groovy:
##########
@@ -73,5 +98,13 @@ suite("test_complex_disallowed_subtypes") {
PROPERTIES('replication_num'='1')
"""
+ sql """
+ CREATE TABLE t_complex_map_key_valid (k INT, v MAP<STRING, ARRAY<INT>>)
+ DUPLICATE KEY(k)
+ DISTRIBUTED BY HASH(k) BUCKETS 1
+ PROPERTIES('replication_num'='1')
+ """
+
sql "DROP TABLE IF EXISTS t_complex_valid"
Review Comment:
Please remove this post-test drop. The suite already drops
`t_complex_map_key_valid` before creating it, and the regression-test
convention in `AGENTS.md` is to avoid dropping tables after the test so the
final state remains available for debugging.
##########
regression-test/suites/datatype_p0/nested_types/string_len/test_string_len_complex.groovy:
##########
@@ -200,42 +200,4 @@ suite("test_string_len_complex") {
}
qt_sql_map_all2 """ select * from test_string_len_map_one_level order by
id; """
- // test map two level
Review Comment:
This removes the only two-level MAP string-length coverage from this suite.
The old table shape is invalid because the top-level key is `MAP<...>`, but the
new rule still allows nested complex values, so the test can be rewritten as
something like `MAP<CHAR(11), MAP<CHAR(11), CHAR(11)>>` and keep the
strict/non-strict insert assertions. As written, a change that breaks CHAR
truncation inside nested MAP values would no longer be caught by this
regression suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
