wyxxxcat opened a new pull request, #65142:
URL: https://github.com/apache/doris/pull/65142
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: In 4.1.2-tmp-rc03 release regression, Docker Case and S3
Docker Case failed broadly during docker-compose cluster startup. The storage
vault snapshot change reads `args.env` in `doris-compose.py up` to check
`ENABLE_STORAGE_VAULT`, but the affected release branch can run with an
argparse `Namespace` that does not define `env`. This causes `AttributeError:
'Namespace' object has no attribute 'env'` before the test cluster is created,
blocking docker-based regression suites.
This change reads the optional `env` argument with `getattr(args, 'env',
None)` once and reuses that value for both `ENABLE_STORAGE_VAULT` parsing and
`Cluster.new()`. When the argument is absent, the default behavior is
unchanged: no extra environment variables are passed and storage vault remains
disabled.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
