github-actions[bot] commented on code in PR #65021:
URL: https://github.com/apache/doris/pull/65021#discussion_r3511078042
##########
be/src/exec/rowid_fetcher.cpp:
##########
@@ -589,7 +612,7 @@ Status RowIdStorageReader::read_by_rowids(const
PMultiGetRequestV2& request,
RETURN_IF_ERROR(read_batch_doris_format_row(
request_block_desc, id_file_map, slots,
tquery_id, result_blocks[i],
stats, &acquire_tablet_ms, &acquire_rowsets_ms,
- &acquire_segments_ms, &lookup_row_data_ms));
+ &acquire_segments_ms, &lookup_row_data_ms,
file_cache_miss_policy));
} else {
RETURN_IF_ERROR(read_batch_external_row(
request.wg_id(), request_block_desc,
id_file_map, slots,
Review Comment:
Here the external-table branch drops the new
`file_cache_remote_only_on_miss` policy. The request bit is converted above and
passed to the internal Doris-format path, but `read_batch_external_row()`
rebuilds a `RuntimeState` and eventually
`FileScanner::prepare_for_read_lines()` creates an `IOContext` whose
`file_cache_miss_policy` stays at the default `READ_THROUGH_AND_WRITE_BACK`.
Since `CachedRemoteFileReader::read_at_impl()` only enters the no-write path
when the IOContext policy is `REMOTE_ONLY_ON_MISS`, TopN lazy materialization
on external tables will still write file-cache blocks on cold misses even with
the new session variable enabled. Please thread the policy into the external
phase-2 scanner IO context, and cover an external-table miss case so
`WriteCacheBytes` stays zero there too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
