github-actions[bot] commented on code in PR #65121: URL: https://github.com/apache/doris/pull/65121#discussion_r3518059639
########## .github/workflows/code-checks.yml: ########## @@ -17,7 +17,12 @@ name: Code Checks -on: [push, pull_request_target] +on: + push: + branches: + - master + - branch-* Review Comment: `branch-*` is still broad enough to include ordinary upstream development heads, so it leaves the duplicate push+PR workflow runs this PR is trying to avoid. Live branch metadata currently has unprotected matches such as `branch-catalog-spi`, `branch-fs-spi`, `branch-hudi-mtmv`, `branch-refactor_property`, and `branch-4.1-fix-spill`; pushing to any of those with an open PR would still trigger both the `push` run here and the `pull_request_target` run. Please restrict this to the actual long-lived release branches that should keep push CI, or add explicit exclusions for branch-named feature heads. ########## .github/workflows/lfs-warning.yml: ########## @@ -18,7 +18,12 @@ --- name: 'Check Large File' -on: [push, pull_request_target] +on: + push: + branches: + - master + - branch-* Review Comment: Same issue as in `code-checks.yml`: `branch-*` still matches branch-named upstream development heads such as `branch-catalog-spi`, `branch-fs-spi`, `branch-hudi-mtmv`, `branch-refactor_property`, and `branch-4.1-fix-spill`. Those pushes would continue to run this workflow in addition to the `pull_request_target` run for an open PR, so the push filter should be narrowed to the intended long-lived release branches or explicitly exclude branch-named feature heads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
