morrySnow commented on PR #64366: URL: https://github.com/apache/doris/pull/64366#issuecomment-4874553492
Update for https://github.com/apache/doris/pull/64366#issuecomment-4863750429 and the latest review: pushed 3bd0f4ebf16 to `fix-now`. Handled the remaining items by: - leaving FE statement-time functions unfolded when precision arguments are unsupported, including `curtime(NULL)` / `current_time(NULL)`, instead of throwing from literal casts; - restricting FE statement-time timezone resolution to BE-compatible aliases, so unsupported Java-only aliases such as `PST` are evaluated on BE instead of mixed FE/BE timezones; - restoring the original broker-load `StatementContext` after planning and passing the broker task statement start time into coordinator creation; - using `CoordinatorContext.setQueryTime(...)` in BE constant folding so `now_string`, `timestamp_ms`, and `nano_seconds` all use the same statement instant. Checks run: `git diff --check`, `mvn checkstyle:check -pl fe-core`. I also attempted `./run-fe-ut.sh --run org.apache.doris.nereids.rules.expression.FoldConstantTest`, but it failed before fe-core because `fe-grpc` generated `ColumnDataFile.java` references missing `OlapCommon.ColumnMessage`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
