github-actions[bot] commented on code in PR #65173:
URL: https://github.com/apache/doris/pull/65173#discussion_r3519471373
##########
fe/fe-core/src/main/java/org/apache/doris/plugin/AuditEvent.java:
##########
@@ -160,6 +160,12 @@ public enum EventType {
public String workloadGroup = "";
@AuditField(value = "ComputeGroupName", colName = "compute_group")
public String cloudClusterName = "";
+ // resource group affinity decision of this statement; preferred group is
empty when no
+ // effective group was resolved (affinity inactive)
+ @AuditField(value = "EffectivePreferredResourceGroup", colName =
"effective_preferred_resource_group")
Review Comment:
These new audit fields are populated for the text audit event, but the
built-in audit table path is still missing them. `AuditLoader.fillLogBuffer()`
is documented as matching `InternalSchema.AUDIT_SCHEMA`, and today that tail
still writes only `workloadGroup`, `cloudClusterName`, then `stmt`; the schema
likewise has only `workload_group`, `compute_group`, then `stmt`, and
`AuditStreamLoader` builds its stream-load `columns` header from that schema.
With the audit loader enabled, `internal.__internal_schema.audit_log` will
silently omit `effective_preferred_resource_group` and
`resource_group_select_policy` even though the text audit line has them. Please
add the two columns to `InternalSchema.AUDIT_SCHEMA`, append the matching
values in `AuditLoader.fillLogBuffer()` in the same order, and cover the
ordering with a schema/buffer test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
