github-actions[bot] commented on code in PR #64854:
URL: https://github.com/apache/doris/pull/64854#discussion_r3526153691
##########
be/test/format/orc/orc_reader_fill_data_test.cpp:
##########
@@ -125,6 +141,26 @@ TEST_F(OrcReaderFillDataTest, TestFillLongColumnWithNull) {
}
}
+TEST_F(OrcReaderFillDataTest, TimestampDecodeNormalizesCstTimezone) {
+ auto batch = create_timestamp_batch(1, {1577905445}, {321000000});
+ auto data_type = std::make_shared<DataTypeDateTimeV2>(6);
+ auto column = data_type->create_column();
+ auto orc_type_ptr = createPrimitiveType(orc::TypeKind::TIMESTAMP);
+
+ TFileScanRangeParams params;
+ TFileRangeDesc range;
+ auto reader = OrcReader::create_unique(params, range, 4064, "CST",
nullptr, nullptr, true);
Review Comment:
This test is not isolated. `OrcReader::create_unique(..., "CST", ...)` now
resolves the reader timezone via
`find_cctz_time_zone(normalized_orc_timezone_name(ctz), _time_zone)`, so the
constructor looks up `Asia/Shanghai`. Named zones are only present after
`TimezoneUtils::load_timezones_to_cache()`, but the BE UT main does not load
that cache and this fixture's `SetUp()` is empty. A filtered run of just this
test can therefore depend on another test having populated the cache first,
otherwise the reader decodes with the default UTC zone and the `2020-01-02
03:04:05.321000` assertion fails. Please load the timezone cache in this
fixture/test before constructing the `"CST"` reader, as the other
timezone-dependent BE UTs do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
