github-actions[bot] commented on code in PR #65214:
URL: https://github.com/apache/doris/pull/65214#discussion_r3526238246


##########
regression-test/suites/load_p0/routine_load/test_routine_load_error_info.groovy:
##########
@@ -48,7 +48,7 @@ suite("test_routine_load_error_info","nonConcurrent") {
 
     def createTable = {tableName ->
         sql """
-            DROP TABLE IF EXISTS ${tableName}
+            DROP TABLE IF EXISTS ${tableName} FORCE

Review Comment:
   `DROP TABLE ... FORCE` only removes the table; it does not synchronously 
clear the routine-load label. This suite reuses fixed labels such as 
`test_error_info` immediately after `createTable`, and 
`RoutineLoadManager.isNameUsed` rejects a new `CREATE ROUTINE LOAD` while any 
old same-name job is still `NEED_SCHEDULE`, `RUNNING`, or `PAUSED`. If a 
previous run was interrupted, or if the new best-effort cleanup swallowed a 
stop failure, the forced drop can leave the old job non-final until the 
routine-load scheduler later notices the missing table and cancels it, so the 
rerun still fails with `Name ... already used`. Please clear the label as part 
of setup too, for example by best-effort stopping the known job before the 
forced drop and waiting for it to become final, or by using unique per-case job 
names.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to