github-actions[bot] commented on code in PR #65083:
URL: https://github.com/apache/doris/pull/65083#discussion_r3526262490
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/maxcompute/source/MaxComputeScanNode.java:
##########
@@ -408,8 +408,8 @@ private Predicate convertExprToOdpsPredicate(Expr expr)
throws AnalysisException
InPredicate inPredicate = (InPredicate) expr;
com.aliyun.odps.table.optimizer.predicate.InPredicate.Operator
odpsOp =
inPredicate.isNotIn()
- ?
com.aliyun.odps.table.optimizer.predicate.InPredicate.Operator.IN
- :
com.aliyun.odps.table.optimizer.predicate.InPredicate.Operator.NOT_IN;
+ ?
com.aliyun.odps.table.optimizer.predicate.InPredicate.Operator.NOT_IN
Review Comment:
The current PR head still has `check_coverage_fe (Coverage)` failing, and
the only new coverage for this branch is a MaxCompute regression suite gated by
`enableMaxComputeTest`. That suite is useful end-to-end coverage, but it does
not execute in the FE coverage job, so the changed `isNotIn()` mapping here
remains uncovered locally. `MaxComputeScanNodeTest` already builds
`InPredicate` values and uses reflection for private helpers; please add a
focused FE unit test there that invokes `convertExprToOdpsPredicate` for both
`IN` and `NOT IN` and asserts the generated ODPS predicate uses the matching
polarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
