github-actions[bot] commented on code in PR #65260:
URL: https://github.com/apache/doris/pull/65260#discussion_r3528089055
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/materialize/MaterializeProbeVisitor.java:
##########
@@ -152,7 +154,8 @@ public Optional<MaterializeSource>
visitPhysicalOlapScan(PhysicalOlapScan scan,
if (scan.getOperativeSlots().contains(context.slot)) {
return Optional.empty();
}
- return Optional.of(new MaterializeSource(scan, context.slot));
Review Comment:
This still does not get the nested access paths to BE. The visitor now
returns the relation output slot, but the slot that becomes the materialization
tuple descriptor is rebuilt later from the original lazy slot:
`PhysicalLazyMaterialize` does `((SlotReference)
lazySlot).withColumn(originalColumn)`, and `withColumn()` does not copy
`allAccessPaths`/`predicateAccessPaths`.
`generateTupleDesc(materialize.getOutput(), ...)` therefore creates a
`SlotDescriptor` with empty access paths, so the new `set_slot_access_paths()`
calls in BE are a no-op for the targeted rowid fetch. Please carry
`MaterializeSource.baseSlot`'s access paths onto the lazy output slot that is
serialized for the fetch request, and add a test that checks the
materialization tuple descriptor contains those paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
