xylaaaaa opened a new pull request, #65183:
URL: https://github.com/apache/doris/pull/65183
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
This PR adds ORC support to the format v2 file reader path.
- Adds `format_v2/orc/OrcReader` and ORC SearchArgument lowering.
- Wires `FileFormat::ORC` into `TableReader::create_file_reader`.
- Localizes ORC filters through file-local conjuncts and predicate filters
for SARG/statistics pruning.
- Adds predicate literal accessors required by ORC SARG lowering for
comparison and IN-list predicates.
- Adds format v2 ORC reader tests and Hive ORC positional mapping coverage.
### Release note
Add ORC reader support for file scanner v2.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
Manual verification:
```bash
git diff --check
```
```bash
rg -n
"reader_expression_map|FileNestedPredicateTarget|FileStructPredicateTarget|child_id_path|column_filter\\.target|PredicateColumnType|predicate_column\\.h"
be/src/format_v2 be/test/format_v2 be/src/storage/predicate
```
The following source groups were also checked with `clang++ -fsyntax-only`
using the existing BE compile command flags:
```text
be/src/format_v2/orc/orc_search_argument.cpp: exit 0
be/src/format_v2/orc/orc_reader.cpp: exit 0
be/src/format_v2/table_reader.cpp: exit 0
be/src/format_v2/table/hive_reader.cpp: exit 0
be/src/storage/predicate/predicate_creator_comparison.cpp: exit 0
be/src/storage/predicate/predicate_creator_in_list_in.cpp: exit 0
be/src/storage/predicate/predicate_creator_in_list_not_in.cpp: exit 0
be/test/format_v2/orc/orc_reader_test.cpp: exit 0
be/test/format_v2/table/hive_reader_test.cpp: exit 0
```
Full local CMake build could not be completed in this workspace because
configure fails before generating `build.ninja` in `contrib/openblas`:
```text
Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)
```
- Behavior changed:
- [ ] No.
- [x] Yes. Adds ORC reader support to the format v2 scan path.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
