github-actions[bot] commented on code in PR #65226:
URL: https://github.com/apache/doris/pull/65226#discussion_r3533198847
##########
regression-test/suites/audit/test_audit_log_queue_time.groovy:
##########
@@ -110,10 +118,7 @@ suite("test_audit_log_queue_time", "nonConcurrent") {
auditResult = sql "${query}"
}
- auditResult.each { row ->
- assertTrue(row[1] >= sqlSleepTime * 1000)
- }
-
+ log.info("audit queue time result for marker ${testMarker}:
${auditResult}")
assertTrue(auditResult.size() >= queuedSqlCnt)
Review Comment:
This assertion has become too weak. `auditResult` only contains rows whose
`stmt` includes the marker and whose `queue_time_ms` is positive, then line 122
counts any such row. A tiny positive token delta is possible even for an
immediately admitted query because `queue_time_ms` is just
`QueueToken.getQueueEndTime() - getQueueStartTime()`, and the audit-table
polling SQL itself embeds `${testMarker}` in its `LIKE` predicate, so it can be
audited and satisfy this condition without proving that the second `sleep(5)`
worker waited behind the first one. Now that the workers are synchronized
before the `select`, please keep the barrier but assert a meaningful
queued-worker condition again, for example count rows for the `select
sleep(...)` statements whose `queue_time_ms` is near the expected wait
duration, or compare against an observed start/admission interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
