github-actions[bot] commented on code in PR #65171:
URL: https://github.com/apache/doris/pull/65171#discussion_r3534591838
##########
fe/fe-core/src/main/java/org/apache/doris/fs/SchemaTypeMapper.java:
##########
@@ -87,7 +87,8 @@ public enum SchemaTypeMapper {
HDFS("hdfs", StorageProperties.Type.HDFS, FileSystemType.HDFS,
TFileType.FILE_HDFS),
LOCAL("local", StorageProperties.Type.HDFS, FileSystemType.HDFS,
TFileType.FILE_HDFS),
HTTP("http", StorageProperties.Type.HTTP, FileSystemType.HTTP,
TFileType.FILE_HTTP),
- HTTPS("https", StorageProperties.Type.HTTP, FileSystemType.HTTP,
TFileType.FILE_HTTP);
+ HTTPS("https", StorageProperties.Type.HTTP, FileSystemType.HTTP,
TFileType.FILE_HTTP),
+ BOS("bos", StorageProperties.Type.S3, FileSystemType.S3,
TFileType.FILE_S3);
Review Comment:
This makes the normal `LocationPath`/Iceberg scan path treat `bos://` as S3,
but the `test_connection=true` catalog-creation path still has its own scheme
checks. `ExternalCatalog.checkWhenCreating()` runs
`CatalogConnectivityTestCoordinator`; for Iceberg Glue, `getTestLocation()`
rejects any warehouse that does not match `^(s3|s3a|s3n)://`, so a `bos://...`
Glue warehouse still fails before users reach the fixed scan path. For
HMS/REST, the base tester can return the configured `bos://` warehouse, but
`findMatchingObjectStorage()` only matches `s3://`/`s3a://`, so the
S3-compatible BOS storage test is skipped. Please route this path through the
same `SchemaTypeMapper`/`LocationPath` normalization or add `bos` to the
connectivity validation/matching logic, and cover a `bos://` Iceberg warehouse
with `test_connection=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
