github-actions[bot] commented on code in PR #65340:
URL: https://github.com/apache/doris/pull/65340#discussion_r3536645563
##########
regression-test/suites/insert_p0/test_insert_visible_timeout_return_mode.groovy:
##########
@@ -24,10 +25,12 @@ suite("test_insert_visible_timeout_return_mode",
"nonConcurrent") {
}
def debugPoint = "PublishVersionDaemon.stop_publish"
- // Use the configured FE HTTP endpoint so the case also works when SHOW
FRONTENDS exposes loopback addresses.
- def feHttpAddress = context.config.feHttpAddress
- def feHost = feHttpAddress.split(":")[0]
- def feHttpPort = Integer.parseInt(feHttpAddress.split(":")[1])
+ // PublishVersionDaemon runs on the master FE, so keep both the session
and debug point on master.
+ def feHost = getMasterIp()
Review Comment:
This reintroduces the endpoint problem that the removed block was guarding
against. `getMasterIp()` returns `Host` from `frontends()`, and this value is
now used both for `DebugPoint.enableDebugPoint(...)` and for the rebuilt JDBC
URL. In the pipeline configs the runner-facing endpoints are carried
separately, for example `jdbcUrl = jdbc:mysql://172.19.0.2:9131/...` and
`feHttpAddress = 172.19.0.2:8131`, while the old comment explicitly avoided
`SHOW FRONTENDS` because it can expose loopback/internal addresses. On those
deployments the test will fail before reaching the visible-timeout path even
though the configured endpoints are reachable. Please keep the master pinning,
but resolve it through runner-reachable regression/cluster metadata or preserve
the configured host when switching to the master's query/http ports instead of
using raw `frontends().Host`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
