github-actions[bot] commented on code in PR #65353:
URL: https://github.com/apache/doris/pull/65353#discussion_r3541179558
##########
fe/fe-core/src/main/java/org/apache/doris/qe/QeProcessorImpl.java:
##########
@@ -74,35 +74,79 @@ private QeProcessorImpl() {
}
private Status processQueryProfile(TQueryProfile profile, TNetworkAddress
address, boolean isDone) {
+ String queryId = DebugUtil.printId(profile.query_id);
+ String reportedFragments = getQueryProfileFragmentIds(profile);
ExecutionProfile executionProfile =
ProfileManager.getInstance().getExecutionProfile(profile.query_id);
if (executionProfile == null) {
// When auto_profile_threshold_ms is not -1, this branch will be
very common.
// So this log is set to debug level.
- if (LOG.isDebugEnabled()) {
- LOG.debug("Could not find execution profile, query {} be {}",
- DebugUtil.printId(profile.query_id),
address.toString());
+ if (isDone) {
Review Comment:
This turns an expected profile-filtering path into a WARN. The comment above
still says missing execution profiles are common when
`auto_profile_threshold_ms != -1`; for short queries
`Profile.updateSummary(..., true)` removes the profile via
`ProfileManager.removeProfile()`, and a final BE profile report that arrives
after that cleanup reaches this branch with `isDone=true`. Those successful
threshold-filtered queries will now emit `WARN` even though nothing is wrong,
which makes the diagnostic noisy and can hide the real lost-profile case.
Please keep the known filtered/cleaned-up miss at DEBUG, or only warn when the
miss is distinguishable from intentional auto-profile cleanup, for example
while the coordinator still exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
