Gabriel39 opened a new pull request, #65370:
URL: https://github.com/apache/doris/pull/65370

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: None
   
   Problem Summary: Reading Iceberg struct fields after Spark schema evolution 
can materialize a column whose root nullability does not match the declared 
file type used to prepare the cast expression. The cast wrapper unwraps 
nullable inputs based on the declared input type, so a nullable declared type 
with a non-nullable actual column can hit an invalid unwrap path and crash BE 
instead of returning the cast result. This change aligns the declared cast 
input root nullability with the actual column shape before executing the cast. 
It also adds a focused BE unit test and an Iceberg regression case that creates 
a Spark Iceberg struct, evolves col.a from INT to BIGINT, refreshes the Doris 
catalog, and queries col.a/col.b/col.c with nested pruning enabled.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test: Manual test
       - Ran git diff --check for modified files
       - Ran targeted clang-format v16 wrapper for modified BE C++ files
       - Attempted BE unit test: ./run-be-ut.sh --run 
--filter=TableReaderTest.ComplexRematerializeCastsNonNullableScalarChildWithNullableFileType:TableReaderTest.ComplexRematerializeCastsScalarChildToTableType,
 blocked because local thirdparty/installed is incomplete (missing bin/protoc 
and Snappy)
       - Attempted regression test: ./run-regression-test.sh --run -d 
external_table_p0/iceberg -s test_iceberg_struct_schema_evolution, blocked 
because local thirdparty/installed is incomplete (missing bin/thrift)
   - Behavior changed: No
   - Does this need documentation: No
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to