HappenLee commented on code in PR #64624:
URL: https://github.com/apache/doris/pull/64624#discussion_r3543611525
##########
be/src/exprs/aggregate/aggregate_function_null.h:
##########
@@ -346,6 +376,9 @@ class AggregateFunctionNullUnaryInline final
void add(AggregateDataPtr __restrict place, const IColumn** columns,
ssize_t row_num,
Review Comment:
if (this->const_argument_idx[i]) {
nested_columns[i] = nullptr;
continue;
} 这里应该补个注释，如果是单参数的话，如果有const的话，也应该这么处理.
那只是因为你包含的case里面没有单参数const的情况.或者我们得想一下单参数的情况怎么完美处理一下const
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
