github-actions[bot] commented on code in PR #65379:
URL: https://github.com/apache/doris/pull/65379#discussion_r3543845070
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/S3Util.java:
##########
@@ -434,6 +430,13 @@ public static void validateAndTestEndpoint(String
endpoint) throws UserException
}
}
+ static String buildEndpointUrl(String endpoint) {
+ if (endpoint.startsWith("http://";) || endpoint.startsWith("https://";))
{
+ return endpoint;
+ }
+ return "https://"; + endpoint;
Review Comment:
This only changes the load/TVF endpoint validation path, but other
scheme-less object-storage endpoints still keep the old HTTP behavior. For
example, `S3Resource.setProperties()` still rewrites and persists scheme-less
resources/vaults as `http://...`, `CreateStageCommand.tryConnect()` still
validates external stages with `http://` + endpoint,
`DLFCatalog.initializeFileIO()` still prepends `http://` before building its S3
client, and the S3/Minio catalog connectivity tester passes a scheme-less
endpoint straight to `URI.create(endpoint)`. Those paths do not go through this
helper, so users of `CREATE RESOURCE`, S3 storage vaults, external stages, DLF
Iceberg catalogs, or catalog connectivity checks can still miss the new HTTPS
default after this PR. Please route these parallel paths through the same
HTTPS-default normalization while preserving explicit `http://`, and update the
tests that currently pin or miss the old behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
